From: Jason Wessel <jason.wessel@windriver.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix regression against commit 4259
Date: Sat, 26 Apr 2008 16:30:50 -0500 [thread overview]
Message-ID: <48139F0A.6090706@windriver.com> (raw)
Stuart Brady found a regression based on the 4259 commit where
DNS via slirp to the special address does not work properly.
I verified that DNS to the default special address 10.0.2.3 does not
work. When using the "special address" for DNS it must be treated as
a special case. In the original 4259, I did not have a test case for
the loopback DNS. The translation logic should be used in this case
as well as for any loopback directed requests.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
slirp/udp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -318,11 +318,12 @@ int udp_output(struct socket *so, struct
struct sockaddr_in saddr, daddr;
saddr = *addr;
- if ((so->so_faddr.s_addr & htonl(0xffffff00)) == special_addr.s_addr &&
- addr->sin_addr.s_addr == htonl(0x7f000001)) {
- saddr.sin_addr.s_addr = so->so_faddr.s_addr;
+ if ((so->so_faddr.s_addr & htonl(0xffffff00)) == special_addr.s_addr) {
if ((so->so_faddr.s_addr & htonl(0x000000ff)) == htonl(0xff))
saddr.sin_addr.s_addr = alias_addr.s_addr;
+ else if (addr->sin_addr.s_addr == htonl(0x7f000001) ||
+ ((so->so_faddr.s_addr & htonl(CTL_DNS)) == htonl(CTL_DNS)))
+ saddr.sin_addr.s_addr = so->so_faddr.s_addr;
}
daddr.sin_addr = so->so_laddr;
daddr.sin_port = so->so_lport;
next reply other threads:[~2008-04-26 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 21:30 Jason Wessel [this message]
2008-04-27 22:42 ` [Qemu-devel] [PATCH] Fix regression against commit 4259 andrzej zaborowski
2008-04-28 12:50 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48139F0A.6090706@windriver.com \
--to=jason.wessel@windriver.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).