From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] musicpal: Fix output level of 8-bit samples
Date: Sun, 27 Apr 2008 12:46:18 +0200 [thread overview]
Message-ID: <4814597A.60008@web.de> (raw)
I've still no test case for this, but looking at the code again, the
following makes a bit more sense.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/musicpal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/hw/musicpal.c
===================================================================
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -270,15 +270,15 @@ static void audio_callback(void *opaque,
return;
if (s->playback_mode & MP_AUDIO_16BIT_SAMPLE)
- memcpy(wm8750_dac_buffer(s->wm, block_size >> 2),
+ memcpy(wm8750_dac_buffer(s->wm, block_size >> 2),
(uint32_t *)(s->target_buffer + s->play_pos),
block_size);
else {
codec_buffer = wm8750_dac_buffer(s->wm, block_size >> 1);
for (pos = 0; pos < block_size; pos += 2) {
- *codec_buffer++ = cpu_to_le16(2 *
+ *codec_buffer++ = cpu_to_le16(256 *
*(int8_t *)(s->target_buffer + s->play_pos + pos));
- *codec_buffer++ = cpu_to_le16(2 *
+ *codec_buffer++ = cpu_to_le16(256 *
*(int8_t *)(s->target_buffer + s->play_pos + pos + 1));
}
}
reply other threads:[~2008-04-27 10:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4814597A.60008@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).