From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jq4Ok-0004zN-77 for qemu-devel@nongnu.org; Sun, 27 Apr 2008 06:46:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jq4Oi-0004xo-M9 for qemu-devel@nongnu.org; Sun, 27 Apr 2008 06:46:21 -0400 Received: from [199.232.76.173] (port=56533 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jq4Oi-0004xh-F1 for qemu-devel@nongnu.org; Sun, 27 Apr 2008 06:46:20 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jq4Oi-000183-2X for qemu-devel@nongnu.org; Sun, 27 Apr 2008 06:46:20 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate01.web.de (Postfix) with ESMTP id C24B1DCF920E for ; Sun, 27 Apr 2008 12:46:18 +0200 (CEST) Received: from [88.64.4.240] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1Jq4Og-0002aE-00 for qemu-devel@nongnu.org; Sun, 27 Apr 2008 12:46:18 +0200 Message-ID: <4814597A.60008@web.de> Date: Sun, 27 Apr 2008 12:46:18 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Sender: jan.kiszka@web.de Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] musicpal: Fix output level of 8-bit samples Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org I've still no test case for this, but looking at the code again, the following makes a bit more sense. Signed-off-by: Jan Kiszka --- hw/musicpal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/hw/musicpal.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -270,15 +270,15 @@ static void audio_callback(void *opaque, return; =20 if (s->playback_mode & MP_AUDIO_16BIT_SAMPLE) - memcpy(wm8750_dac_buffer(s->wm, block_size >> 2),=20 + memcpy(wm8750_dac_buffer(s->wm, block_size >> 2), (uint32_t *)(s->target_buffer + s->play_pos), block_size); else { codec_buffer =3D wm8750_dac_buffer(s->wm, block_size >> 1); for (pos =3D 0; pos < block_size; pos +=3D 2) { - *codec_buffer++ =3D cpu_to_le16(2 * + *codec_buffer++ =3D cpu_to_le16(256 * *(int8_t *)(s->target_buffer + s->play_pos + pos)); - *codec_buffer++ =3D cpu_to_le16(2 * + *codec_buffer++ =3D cpu_to_le16(256 * *(int8_t *)(s->target_buffer + s->play_pos + pos + 1= )); } }