From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JqNXO-0005fl-2U
	for qemu-devel@nongnu.org; Mon, 28 Apr 2008 03:12:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JqNXL-0005b3-Ui
	for qemu-devel@nongnu.org; Mon, 28 Apr 2008 03:12:33 -0400
Received: from [199.232.76.173] (port=60998 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JqNXL-0005aF-Gn
	for qemu-devel@nongnu.org; Mon, 28 Apr 2008 03:12:31 -0400
Received: from mx20.gnu.org ([199.232.41.8])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <avi@qumranet.com>) id 1JqNXL-00066f-0V
	for qemu-devel@nongnu.org; Mon, 28 Apr 2008 03:12:31 -0400
Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]
	helo=il.qumranet.com) by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@qumranet.com>) id 1JqNXK-0002kI-Fo
	for qemu-devel@nongnu.org; Mon, 28 Apr 2008 03:12:30 -0400
Message-ID: <48157890.7070101@qumranet.com>
Date: Mon, 28 Apr 2008 10:11:12 +0300
From: Avi Kivity <avi@qumranet.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [Patch] [kinda-resend] persistent real-time-clock
References: <20080427154501.GA20547@karma.qumranet.com>
	<4814AC4E.2080902@qumranet.com>
	<20080428065438.GA6184@karma.qumranet.com>
In-Reply-To: <20080428065438.GA6184@karma.qumranet.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dan Kenigsberg <danken@qumranet.com>
Cc: qemu-devel@nongnu.org

Dan Kenigsberg wrote:
> On Sun, Apr 27, 2008 at 07:39:42PM +0300, Avi Kivity wrote:
>   
>> Dan Kenigsberg wrote:
>>     
>>> Real PC lets its user set the real-time-clock and store it on CMOS,
>>> which advances the clock even when the PC is offline.
>>>
>>> These patches will allow doing the same with VM:
>>> - Before shutting a VM down, use the monitor's info timeoffset to see
>>>   how much (in seconds) does the rtc differ from the host clock.
>>> - Store this offset somewhere.
>>> - Use it next time with -startdate now+offset.
>>>
>>> Please tell me what do you think of it.
>>>   
>>>       
>> How about (additionally) modifying -startdate to accept an offset directly?
>>
>>   qemu -startdate +0300 ...
>>
>> Useful for those Windows VMs which have localtime in cmos.
>>     
>
> I'm missing somthing: in what way is it different than the suggested
>
>     qemu -startdate now+offset ?
>
> Only in allowing to specify the offset in hours/minutes?
>
>   

The difference is that I didn't read your patch, only the description.

I assumed you meant the user calculates now + offset and enters the 
result as the argument to -startdate, but you're not doing that.  Sorry 
for the noise.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.