From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] FDC: Fix data transfer len
Date: Tue, 29 Apr 2008 19:15:20 +0200 [thread overview]
Message-ID: <481757A8.9010706@reactos.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
Hi,
In floppy controller, transfer data len is not correctly calculated.
We should read up to the last sector specified by the caller, and not up
to the last sector of the floppy.
Attached patch fixes this issue.
Hervé
[-- Attachment #2: fdc_data_len.diff --]
[-- Type: text/plain, Size: 562 bytes --]
Index: hw/fdc.c
===================================================================
--- hw/fdc.c (revision 4290)
+++ hw/fdc.c (working copy)
@@ -1137,9 +1137,9 @@
} else {
int tmp;
fdctrl->data_len = 128 << (fdctrl->fifo[5] > 7 ? 7 : fdctrl->fifo[5]);
- tmp = (cur_drv->last_sect - ks + 1);
+ tmp = (fdctrl->fifo[6] - ks + 1);
if (fdctrl->fifo[0] & 0x80)
- tmp += cur_drv->last_sect;
+ tmp += fdctrl->fifo[6];
fdctrl->data_len *= tmp;
}
fdctrl->eot = fdctrl->fifo[6];
reply other threads:[~2008-04-29 17:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481757A8.9010706@reactos.org \
--to=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).