From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDVPi-0007WV-9P for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDVPd-0000NH-QI for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:24:45 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:46138 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDVPd-0000LV-EA for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:24:41 -0400 From: Paul Durrant Date: Thu, 16 Jun 2016 11:24:38 +0000 Message-ID: <481f9b77db71494d81ea43dada59abf0@AMSPEX02CL03.citrite.net> References: <1466071320-10964-1-git-send-email-jgross@suse.com> In-Reply-To: <1466071320-10964-1-git-send-email-jgross@suse.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juergen Gross , "qemu-devel@nongnu.org" , "xen-devel@lists.xensource.com" Cc: Anthony Perard , "sstabellini@kernel.org" , "kraxel@redhat.com" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYZW4tZGV2ZWwgW21haWx0bzp4 ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW4ub3JnXSBPbiBCZWhhbGYgT2YNCj4gSnVlcmdlbiBH cm9zcw0KPiBTZW50OiAxNiBKdW5lIDIwMTYgMTE6MDINCj4gVG86IHFlbXUtZGV2ZWxAbm9uZ251 Lm9yZzsgeGVuLWRldmVsQGxpc3RzLnhlbnNvdXJjZS5jb20NCj4gQ2M6IEFudGhvbnkgUGVyYXJk OyBKdWVyZ2VuIEdyb3NzOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOw0KPiBrcmF4ZWxAcmVkaGF0 LmNvbQ0KPiBTdWJqZWN0OiBbWGVuLWRldmVsXSBbUEFUQ0hdIHhlbjogZml4IHFkaXNrIEJMS0lG X09QX0RJU0NBUkQgZm9yIDMyLzY0DQo+IHdvcmQgc2l6ZSBtaXgNCj4gDQo+IEluIGNhc2UgdGhl IHdvcmQgc2l6ZSBvZiB0aGUgZG9tVSBhbmQgcWVtdSBydW5uaW5nIHRoZSBxZGlzayBiYWNrZW5k DQo+IGRpZmZlciBCTEtJRl9PUF9ESVNDQVJEIHdpbGwgbm90IHdvcmsgcmVsaWFibHksIGFzIHRo ZSByZXF1ZXN0DQo+IHN0cnVjdHVyZSBpbiB0aGUgcmluZyBoYXZlIGRpZmZlcmVudCBsYXlvdXRz IGZvciBkaWZmZXJlbnQgd29yZCBzaXplLg0KPiANCj4gQ29ycmVjdCB0aGlzIGJ5IGNvcHlpbmcg dGhlIHJlcXVlc3Qgc3RydWN0dXJlIGluIGNhc2Ugb2YgZGlmZmVyZW50DQo+IHdvcmQgc2l6ZSBl bGVtZW50IGJ5IGVsZW1lbnQgaW4gdGhlIEJMS0lGX09QX0RJU0NBUkQgY2FzZSwgdG9vLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQpXb3Vs ZCBpdCBub3QgYmUgYmV0dGVyIHRvIHJlLWltcG9ydCB0aGUgY2Fub25pY2FsIGJsa2lmIGhlYWRl ciBhcyBhIHdob2xlIHJhdGhlciB0aGFuIGNoZXJyeS1waWNraW5nIGxpa2UgdGhpcz8gWW91J2Qg bmVlZCB0byBwb3N0LXByb2Nlc3MgdG8gbWFpbnRhaW4gc3R5bGUgYW5kIHBvc3NpYmx5IGNoYW5n ZSBzb21lIG5hbWVzIGZvciBjb21wYXRpYmlsaXR5IGV0Yy4gYnV0IHByb2JhYmx5IG5vdGhpbmcg YmV5b25kIHdoYXQgaW5kZW50IGFuZCBhIHNpbXBsZSBbc11lZCBzY3JpcHQgY2FuIGRvLg0KSSBk aWQgYnJvYWRseSB0aGUgc2FtZSB0aGluZyB0byByZS1pbXBvcnQgdGhlIG5ldGlmIGhlYWRlciBp bnRvIExpbnV4IHJlY2VudGx5Lg0KDQogIFBhdWwNCg0KPiAtLS0NCj4gIGh3L2Jsb2NrL3hlbl9i bGtpZi5oIHwgMjAgKysrKysrKysrKysrKysrKysrLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2h3L2Jsb2Nr L3hlbl9ibGtpZi5oIGIvaHcvYmxvY2sveGVuX2Jsa2lmLmgNCj4gaW5kZXggZTNiMTMzYi4uOTY5 MTEyZiAxMDA2NDQNCj4gLS0tIGEvaHcvYmxvY2sveGVuX2Jsa2lmLmgNCj4gKysrIGIvaHcvYmxv Y2sveGVuX2Jsa2lmLmgNCj4gQEAgLTI2LDYgKzI2LDE0IEBAIHN0cnVjdCBibGtpZl94ODZfMzJf cmVxdWVzdCB7DQo+ICAJYmxraWZfc2VjdG9yX3Qgc2VjdG9yX251bWJlcjsvKiBzdGFydCBzZWN0 b3IgaWR4IG9uIGRpc2sgKHIvdyBvbmx5KQ0KPiAqLw0KPiAgCXN0cnVjdCBibGtpZl9yZXF1ZXN0 X3NlZ21lbnQNCj4gc2VnW0JMS0lGX01BWF9TRUdNRU5UU19QRVJfUkVRVUVTVF07DQo+ICB9Ow0K PiArc3RydWN0IGJsa2lmX3g4Nl8zMl9yZXF1ZXN0X2Rpc2NhcmQgew0KPiArICAgIHVpbnQ4X3Qg ICAgICAgIG9wZXJhdGlvbjsgICAgLyogQkxLSUZfT1BfRElTQ0FSRCAgICAgICAgICAgICAgICAg ICAgICovDQo+ICsgICAgdWludDhfdCAgICAgICAgZmxhZzsgICAgICAgICAvKiBucl9zZWdtZW50 cyBpbiByZXF1ZXN0IHN0cnVjdCAgICAgICAgKi8NCj4gKyAgICBibGtpZl92ZGV2X3QgICBoYW5k bGU7ICAgICAgIC8qIG9ubHkgZm9yIHJlYWQvd3JpdGUgcmVxdWVzdHMgICAgICAgICAqLw0KPiAr ICAgIHVpbnQ2NF90ICAgICAgIGlkOyAgICAgICAgICAgLyogcHJpdmF0ZSBndWVzdCB2YWx1ZSwg ZWNob2VkIGluIHJlc3AgICovDQo+ICsgICAgYmxraWZfc2VjdG9yX3Qgc2VjdG9yX251bWJlcjsv KiBzdGFydCBzZWN0b3IgaWR4IG9uIGRpc2sgKHIvdyBvbmx5KSAgKi8NCj4gKyAgICB1aW50NjRf dCAgICAgICBucl9zZWN0b3JzOyAgIC8qICMgb2YgY29udGlndW91cyBzZWN0b3JzIHRvIGRpc2Nh cmQgICAqLw0KPiArfTsNCj4gIHN0cnVjdCBibGtpZl94ODZfMzJfcmVzcG9uc2Ugew0KPiAgCXVp bnQ2NF90ICAgICAgICBpZDsgICAgICAgICAgICAgIC8qIGNvcGllZCBmcm9tIHJlcXVlc3QgKi8N Cj4gIAl1aW50OF90ICAgICAgICAgb3BlcmF0aW9uOyAgICAgICAvKiBjb3BpZWQgZnJvbSByZXF1 ZXN0ICovDQo+IEBAIC00NCw2ICs1MiwxNCBAQCBzdHJ1Y3QgYmxraWZfeDg2XzY0X3JlcXVlc3Qg ew0KPiAgCWJsa2lmX3NlY3Rvcl90IHNlY3Rvcl9udW1iZXI7Lyogc3RhcnQgc2VjdG9yIGlkeCBv biBkaXNrIChyL3cgb25seSkNCj4gKi8NCj4gIAlzdHJ1Y3QgYmxraWZfcmVxdWVzdF9zZWdtZW50 DQo+IHNlZ1tCTEtJRl9NQVhfU0VHTUVOVFNfUEVSX1JFUVVFU1RdOw0KPiAgfTsNCj4gK3N0cnVj dCBibGtpZl94ODZfNjRfcmVxdWVzdF9kaXNjYXJkIHsNCj4gKyAgICB1aW50OF90ICAgICAgICBv cGVyYXRpb247ICAgIC8qIEJMS0lGX09QX0RJU0NBUkQgICAgICAgICAgICAgICAgICAgICAqLw0K PiArICAgIHVpbnQ4X3QgICAgICAgIGZsYWc7ICAgICAgICAgLyogbnJfc2VnbWVudHMgaW4gcmVx dWVzdCBzdHJ1Y3QgICAgICAgICovDQo+ICsgICAgYmxraWZfdmRldl90ICAgaGFuZGxlOyAgICAg ICAvKiBvbmx5IGZvciByZWFkL3dyaXRlIHJlcXVlc3RzICAgICAgICAgKi8NCj4gKyAgICB1aW50 NjRfdCAgICAgICBfX2F0dHJpYnV0ZV9fKChfX2FsaWduZWRfXyg4KSkpIGlkOw0KPiArICAgIGJs a2lmX3NlY3Rvcl90IHNlY3Rvcl9udW1iZXI7Lyogc3RhcnQgc2VjdG9yIGlkeCBvbiBkaXNrIChy L3cgb25seSkgICovDQo+ICsgICAgdWludDY0X3QgICAgICAgbnJfc2VjdG9yczsgICAvKiAjIG9m IGNvbnRpZ3VvdXMgc2VjdG9ycyB0byBkaXNjYXJkICAgKi8NCj4gK307DQo+ICBzdHJ1Y3QgYmxr aWZfeDg2XzY0X3Jlc3BvbnNlIHsNCj4gIAl1aW50NjRfdCAgICAgICBfX2F0dHJpYnV0ZV9fKChf X2FsaWduZWRfXyg4KSkpIGlkOw0KPiAgCXVpbnQ4X3QgICAgICAgICBvcGVyYXRpb247ICAgICAg IC8qIGNvcGllZCBmcm9tIHJlcXVlc3QgKi8NCj4gQEAgLTgyLDcgKzk4LDcgQEAgc3RhdGljIGlu bGluZSB2b2lkIGJsa2lmX2dldF94ODZfMzJfcmVxKGJsa2lmX3JlcXVlc3RfdA0KPiAqZHN0LCBi bGtpZl94ODZfMzJfcmVxdWUNCj4gIAkvKiBQcmV2ZW50IHRoZSBjb21waWxlciBmcm9tIHVzaW5n IHNyYy0+Li4uIGluc3RlYWQuICovDQo+ICAJYmFycmllcigpOw0KPiAgCWlmIChkc3QtPm9wZXJh dGlvbiA9PSBCTEtJRl9PUF9ESVNDQVJEKSB7DQo+IC0JCXN0cnVjdCBibGtpZl9yZXF1ZXN0X2Rp c2NhcmQgKnMgPSAodm9pZCAqKXNyYzsNCj4gKyAgICAgICAgICAgICAgICBzdHJ1Y3QgYmxraWZf eDg2XzMyX3JlcXVlc3RfZGlzY2FyZCAqcyA9ICh2b2lkICopc3JjOw0KPiAgCQlzdHJ1Y3QgYmxr aWZfcmVxdWVzdF9kaXNjYXJkICpkID0gKHZvaWQgKilkc3Q7DQo+ICAJCWQtPm5yX3NlY3RvcnMg PSBzLT5ucl9zZWN0b3JzOw0KPiAgCQlyZXR1cm47DQo+IEBAIC0xMDUsNyArMTIxLDcgQEAgc3Rh dGljIGlubGluZSB2b2lkDQo+IGJsa2lmX2dldF94ODZfNjRfcmVxKGJsa2lmX3JlcXVlc3RfdCAq ZHN0LCBibGtpZl94ODZfNjRfcmVxdWUNCj4gIAkvKiBQcmV2ZW50IHRoZSBjb21waWxlciBmcm9t IHVzaW5nIHNyYy0+Li4uIGluc3RlYWQuICovDQo+ICAJYmFycmllcigpOw0KPiAgCWlmIChkc3Qt Pm9wZXJhdGlvbiA9PSBCTEtJRl9PUF9ESVNDQVJEKSB7DQo+IC0JCXN0cnVjdCBibGtpZl9yZXF1 ZXN0X2Rpc2NhcmQgKnMgPSAodm9pZCAqKXNyYzsNCj4gKyAgICAgICAgICAgICAgICBzdHJ1Y3Qg YmxraWZfeDg2XzY0X3JlcXVlc3RfZGlzY2FyZCAqcyA9ICh2b2lkICopc3JjOw0KPiAgCQlzdHJ1 Y3QgYmxraWZfcmVxdWVzdF9kaXNjYXJkICpkID0gKHZvaWQgKilkc3Q7DQo+ICAJCWQtPm5yX3Nl Y3RvcnMgPSBzLT5ucl9zZWN0b3JzOw0KPiAgCQlyZXR1cm47DQo+IC0tDQo+IDIuNi42DQo+IA0K PiANCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4g WGVuLWRldmVsIG1haWxpbmcgbGlzdA0KPiBYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZw0KPiBodHRw Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwNCg==