From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JtQXi-0007AE-QF
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:01:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JtQXh-00078O-8e
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:01:30 -0400
Received: from [199.232.76.173] (port=39651 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JtQXg-00078A-TI
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:01:28 -0400
Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1JtQXg-0007XE-Em
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:01:28 -0400
Message-ID: <48208DCA.4000706@suse.de>
Date: Tue, 06 May 2008 18:56:42 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
References: <4807514B.9040607@suse.de>
	<200804302305.42741@kevin-wolf.de>	<f43fc5580805010735m75c2e78ua4863dd2a7dddd4a@mail.gmail.com>	<200805011955.00265@kevin-wolf.de>
	<48201A71.3040405@suse.de>
	<f43fc5580805060942p1d1edd18j30b5652a43aca656@mail.gmail.com>
In-Reply-To: <f43fc5580805060942p1d1edd18j30b5652a43aca656@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Laurent Vivier <Laurent.Vivier@bull.net>

Blue Swirl schrieb:
> Well, the patch looks OK. But I try to test the patches before I
> commit and for this I don't know how. Could you give some example test
> cases?

If you want to test that the patch fixes what it promises you only have 
to create a qcow or qcow2 image and start qemu with cache=off for this 
image. This will fail without the patch, and it should work with the 
patch applied. This covers the simple case. For the aio part of the 
patch you can try saving/loading of snapshots. Normal qcow2 operation 
doesn't trigger the aio code path.

Kevin