From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtVYs-000242-QJ for qemu-devel@nongnu.org; Tue, 06 May 2008 18:23:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtVYl-0001yf-HI for qemu-devel@nongnu.org; Tue, 06 May 2008 18:23:02 -0400 Received: from [199.232.76.173] (port=56426 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtVYl-0001yW-8C for qemu-devel@nongnu.org; Tue, 06 May 2008 18:22:55 -0400 Received: from slow2-v.mail.gandi.net ([217.70.178.89]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtVYk-0008Jw-U1 for qemu-devel@nongnu.org; Tue, 06 May 2008 18:22:55 -0400 Received: from relay1-v.mail.gandi.net (relay1-v.mail.gandi.net [217.70.178.75]) by slow2-v.mail.gandi.net (Postfix) with ESMTP id 84A6A21CCC6 for ; Wed, 7 May 2008 00:19:30 +0200 (CEST) Received: from localhost (mfilter6-v.gandi.net [217.70.178.40]) by relay1-v.mail.gandi.net (Postfix) with ESMTP id D810E362AF for ; Wed, 7 May 2008 00:18:29 +0200 (CEST) Received: from relay1-v.mail.gandi.net ([217.70.178.75]) by localhost (mfilter6-v.mgt.gandi.net [217.70.178.40]) (amavisd-new, port 10024) with ESMTP id lBdsssjLS230 for ; Wed, 7 May 2008 00:18:27 +0200 (CEST) Received: from [84.99.204.237] (237.204.99-84.rev.gaoland.net [84.99.204.237]) by relay1-v.mail.gandi.net (Postfix) with ESMTP id 5B5FB362AA for ; Wed, 7 May 2008 00:18:27 +0200 (CEST) Message-ID: <4820D905.4020407@bellard.org> Date: Wed, 07 May 2008 00:17:41 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [4367] Align file accesses with cache=off (Kevin Wolf, Laurent Vivier) References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org A note: in order to avoid uncontrolled recursions, it is better to call the read/write AIO callback outside the aio_read/write (see bdrv_aio_read_em). Personally I would not trust the OS to correctly handle the mix of O_DIRECT and buffered operations, especially if the corresponding file regions intersect ! Fabrice. Blue Swirl wrote: > Revision: 4367 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4367 > Author: blueswir1 > Date: 2008-05-06 17:26:59 +0000 (Tue, 06 May 2008) > > Log Message: > ----------- > Align file accesses with cache=off (Kevin Wolf, Laurent Vivier) > > Modified Paths: > -------------- > trunk/block-raw-posix.c > [...]