qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4367] Align file accesses with cache=off (Kevin Wolf, Laurent Vivier)
Date: Wed, 07 May 2008 18:39:42 +0200	[thread overview]
Message-ID: <4821DB4E.8000806@suse.de> (raw)
In-Reply-To: <f43fc5580805070919h20ecf4f4k3028dd4fc4102251@mail.gmail.com>

Blue Swirl schrieb:
> I still think it is a waste
> of resources if the effort made for the patches gets lost or don't get
> much review like what is happening here very often.

Thank you, there's nothing more to add. This is exactly what I meant.

> Usually I run a set of tests before committing. From the amount of
> breakage fixes and reverts I get the impression that some of the other
> developers test less. Though testing will not catch all deeper
> problems like in this case.

My impression is that most of the commiters only commit their own 
patches (maybe with the exception of Aurelien), but don't want to bother 
with patches from ordinary mailing list subscribers. In comparison to 
other projects, it's quite difficult to get something into qemu and I'd 
not be surprised if this is discouraging people from doing qemu 
development at all.

Apropos revert... ;-) The patch didn't break anything previously 
working, it's just that previously completely broken functionality might 
still be slightly broken. And I've already posted a patch for the 
recursion problem, so I would have preferred committing that one on top 
over reverting the whole thing.

Kevin

  reply	other threads:[~2008-05-07 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 17:27 [Qemu-devel] [4367] Align file accesses with cache=off (Kevin Wolf, Laurent Vivier) Blue Swirl
2008-05-06 22:17 ` Fabrice Bellard
2008-05-06 22:33   ` Anthony Liguori
2008-05-07  7:48   ` Jamie Lokier
2008-05-07  8:16   ` Kevin Wolf
2008-05-07 12:37     ` Jamie Lokier
2008-05-07 13:04       ` Kevin Wolf
2008-05-07 16:19         ` Blue Swirl
2008-05-07 16:39           ` Kevin Wolf [this message]
2008-05-07 16:26         ` Jamie Lokier
2008-05-07 17:23           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4821DB4E.8000806@suse.de \
    --to=kwolf@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).