From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jup9L-0000BC-DE for qemu-devel@nongnu.org; Sat, 10 May 2008 09:30:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jup9J-0000Ay-S3 for qemu-devel@nongnu.org; Sat, 10 May 2008 09:30:07 -0400 Received: from [199.232.76.173] (port=40425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jup9J-0000Av-NF for qemu-devel@nongnu.org; Sat, 10 May 2008 09:30:05 -0400 Received: from relay1-v.mail.gandi.net ([217.70.178.75]:37928) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jup9J-0004rZ-Bp for qemu-devel@nongnu.org; Sat, 10 May 2008 09:30:05 -0400 Received: from localhost (mfilter5-v.gandi.net [217.70.178.39]) by relay1-v.mail.gandi.net (Postfix) with ESMTP id B65AF362AF for ; Sat, 10 May 2008 15:30:03 +0200 (CEST) Received: from relay1-v.mail.gandi.net ([217.70.178.75]) by localhost (mfilter5-v.gandi.net [217.70.178.39]) (amavisd-new, port 10024) with ESMTP id PF0cI37cWQbo for ; Sat, 10 May 2008 15:30:02 +0200 (CEST) Received: from [84.102.211.84] (84.211.102-84.rev.gaoland.net [84.102.211.84]) by relay1-v.mail.gandi.net (Postfix) with ESMTP id DA44C362AA for ; Sat, 10 May 2008 15:30:01 +0200 (CEST) Message-ID: <4825A32B.9090006@bellard.org> Date: Sat, 10 May 2008 15:29:15 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [4406] fixed global variable handling with qemu load/ stores - initial global prologue/epilogue implementation References: <20080510124554.GA19165@miranda.arrow> <20080510131003.GA19279@miranda.arrow> In-Reply-To: <20080510131003.GA19279@miranda.arrow> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stuart Brady wrote: > On Sat, May 10, 2008 at 01:45:54PM +0100, Stuart Brady wrote: >> On Sat, May 10, 2008 at 10:52:06AM +0000, Fabrice Bellard wrote: >> >>> -#ifdef HOST_HPPA >>> - func_addr = (tcg_target_long)__canonicalize_funcptr_for_compare((void *)func_addr); >>> -#endif >> How would you prefer this to be handled? > > Ouch -- I've just noticed that the right place to handle this was > tcg_out_call()... which in fact already does it! > > I obviously meant to remove the __canonicalize_funcptr_for_compare from > tcg.c before I even submitted the code. Thanks for fixing it. > > Another change I made was adding the 'func_addr' variable, and using it > in place of ts->val. I can submit a patch to revert that change if you > would like. An important note: the only "officially" supported hosts for TCG are x86 and x86_64. I prefer not to support other hosts at this point because TCG is evolving. However I accept that code is commited for them provided it does not make heavy change in the TCG core. In order to test a TCG target support, it is important to use a fully converted target such as SPARC. Testing it on non fully converted targets such as x86 only tests a small fraction of the code. Regards, Fabrice.