qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4432] Debugger single step without interrupts (Jason Wessel).
Date: Mon, 12 May 2008 12:08:37 +0200	[thread overview]
Message-ID: <48281725.40602@bellard.org> (raw)
In-Reply-To: <E1JvShu-0003YA-TE@cvs.savannah.gnu.org>

I see no reason why the real time timers should be stopped while single
stepping. These timers have no relation with the emulation.

BTW, it seems that some devices incorrectly use the real time timers...

Regards,

Fabrice.

Edgar E. Iglesias wrote:
> Revision: 4432
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4432
> Author:   edgar_igl
> Date:     2008-05-12 07:44:23 +0000 (Mon, 12 May 2008)
> 
> Log Message:
> -----------
> Debugger single step without interrupts (Jason Wessel).
> 
> Modified Paths:
> --------------
>     trunk/vl.c
> 
> Modified: trunk/vl.c
> ===================================================================
> --- trunk/vl.c	2008-05-11 19:24:10 UTC (rev 4431)
> +++ trunk/vl.c	2008-05-12 07:44:23 UTC (rev 4432)
> @@ -7032,6 +7032,7 @@
>      qemu_aio_poll();
>  
>      if (vm_running) {
> +        if (!(cur_cpu->singlestep_enabled & SSTEP_NOTIMER))
>          qemu_run_timers(&active_timers[QEMU_TIMER_VIRTUAL],
>                          qemu_get_clock(vm_clock));
>          /* run dma transfers, if any */
> @@ -7039,6 +7040,7 @@
>      }
>  
>      /* real time timers */
> +    if (!(cur_cpu->singlestep_enabled & SSTEP_NOTIMER))
>      qemu_run_timers(&active_timers[QEMU_TIMER_REALTIME],
>                      qemu_get_clock(rt_clock));
>  
> 
> 
> 
> 
> 

  reply	other threads:[~2008-05-12 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12  7:44 [Qemu-devel] [4432] Debugger single step without interrupts (Jason Wessel) Edgar E. Iglesias
2008-05-12 10:08 ` Fabrice Bellard [this message]
2008-05-12 10:54   ` Edgar E. Iglesias
2008-05-12 13:16     ` Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48281725.40602@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).