From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JvUzT-0004Kp-4X
	for qemu-devel@nongnu.org; Mon, 12 May 2008 06:10:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JvUzP-0004KA-98
	for qemu-devel@nongnu.org; Mon, 12 May 2008 06:10:40 -0400
Received: from [199.232.76.173] (port=51384 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JvUzN-0004Jq-DB
	for qemu-devel@nongnu.org; Mon, 12 May 2008 06:10:38 -0400
Received: from relay3-v.mail.gandi.net ([217.70.178.77]:60526)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1JvUzM-0004pU-SR
	for qemu-devel@nongnu.org; Mon, 12 May 2008 06:10:37 -0400
Received: from localhost (mfilter3-v.gandi.net [217.70.178.37])
	by relay3-v.mail.gandi.net (Postfix) with ESMTP id 5FB2CBA10
	for <qemu-devel@nongnu.org>; Mon, 12 May 2008 12:10:35 +0200 (CEST)
Received: from relay3-v.mail.gandi.net ([217.70.178.77])
	by localhost (mfilter3-v.mgt.gandi.net [217.70.178.37]) (amavisd-new,
	port 10024) with ESMTP id b4avJxwFO-qI for <qemu-devel@nongnu.org>;
	Mon, 12 May 2008 12:10:29 +0200 (CEST)
Received: from [84.102.211.207] (207.211.102-84.rev.gaoland.net
	[84.102.211.207])
	by relay3-v.mail.gandi.net (Postfix) with ESMTP id AD78EBA13
	for <qemu-devel@nongnu.org>; Mon, 12 May 2008 12:09:29 +0200 (CEST)
Message-ID: <48281725.40602@bellard.org>
Date: Mon, 12 May 2008 12:08:37 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [4432] Debugger single step without interrupts (Jason
	Wessel).
References: <E1JvShu-0003YA-TE@cvs.savannah.gnu.org>
In-Reply-To: <E1JvShu-0003YA-TE@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I see no reason why the real time timers should be stopped while single
stepping. These timers have no relation with the emulation.

BTW, it seems that some devices incorrectly use the real time timers...

Regards,

Fabrice.

Edgar E. Iglesias wrote:
> Revision: 4432
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4432
> Author:   edgar_igl
> Date:     2008-05-12 07:44:23 +0000 (Mon, 12 May 2008)
> 
> Log Message:
> -----------
> Debugger single step without interrupts (Jason Wessel).
> 
> Modified Paths:
> --------------
>     trunk/vl.c
> 
> Modified: trunk/vl.c
> ===================================================================
> --- trunk/vl.c	2008-05-11 19:24:10 UTC (rev 4431)
> +++ trunk/vl.c	2008-05-12 07:44:23 UTC (rev 4432)
> @@ -7032,6 +7032,7 @@
>      qemu_aio_poll();
>  
>      if (vm_running) {
> +        if (!(cur_cpu->singlestep_enabled & SSTEP_NOTIMER))
>          qemu_run_timers(&active_timers[QEMU_TIMER_VIRTUAL],
>                          qemu_get_clock(vm_clock));
>          /* run dma transfers, if any */
> @@ -7039,6 +7040,7 @@
>      }
>  
>      /* real time timers */
> +    if (!(cur_cpu->singlestep_enabled & SSTEP_NOTIMER))
>      qemu_run_timers(&active_timers[QEMU_TIMER_REALTIME],
>                      qemu_get_clock(rt_clock));
>  
> 
> 
> 
> 
>