From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lz67T-0007sX-BF for qemu-devel@nongnu.org; Wed, 29 Apr 2009 05:30:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lz67N-0007op-Qj for qemu-devel@nongnu.org; Wed, 29 Apr 2009 05:30:22 -0400 Received: from [199.232.76.173] (port=54639 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lz67N-0007oU-F9 for qemu-devel@nongnu.org; Wed, 29 Apr 2009 05:30:17 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:42632) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lz67M-00005h-KS for qemu-devel@nongnu.org; Wed, 29 Apr 2009 05:30:17 -0400 In-Reply-To: Subject: Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c =?utf-8?q?into?= usb-hid.c From: "=?utf-8?q?Fran=C3=A7ois?= Revol" Date: Wed, 29 Apr 2009 11:30:29 +0200 CEST Message-Id: <4833947677-BeMail@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schindelin Cc: qemu-devel@nongnu.org > > > > http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=3D40233 > > > > > > > > > > Reading something like this in a Git log, sitting 30k feet above > > > ground, makes me want to do something very foolish. > > To illustrate what commit messages in typical Git repositories look > like: > > http://repo.or.cz/w/git.git=3Fa=3Dcommitdiff;h=3D8d2dfc49b199c7da6faefd7993630f24bd37fee0 > > > (answering a link with a link is okay, I think.) Typical commit line counts in QEMU tends to be quite lower : # count lines $ git log | awk '/^ ..*$/{cnt++;/*print*/};NR>1&&/^commit/{print cnt; cnt=3D"0"}' | sort -g | uniq -c | sort -g -k 1 -r 4904 2 798 3 354 4 255 5 239 6 172 7 103 8 85 9 59 10 36 12 33 11 28 13 21 14 15 18 14 15 9 16 9 1 6 21 6 20 5 17 4 25 4 23 3 24 2 37 2 31 2 26 2 19 1 68 1 62 1 59 1 41 1 38 1 36 1 35 1 34 1 33 1 32 Which isn't a problem in itself... > The point is that nobody needs to sift through long and dispersed > discussions with a lot of points that are moot in the end. If more > than > one person reads the summary of the discussions in the commit > message, the > overall saved time (integrated over all involved people) is > substantial. The problem is everytime I've spent time explaining the patch, like 2 ppl read it and gave thoughtfull comments. Which should be enough but I just got fed up spending hours ingurGITating man pages. Besides, you still didn't even comment on the patch itself yet, which quites asserts this. Fran=C3=A7ois.