From: Jan Kiszka <jan.kiszka@web.de>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] MusicPal: Add specific -hold-button option
Date: Wed, 21 May 2008 09:29:35 +0200 [thread overview]
Message-ID: <4833CF5F.8080908@web.de> (raw)
In-Reply-To: <200805210104.41636.paul@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
Paul Brook wrote:
>> MusicPal's U-Boot is able to start in a special mode (firmware recovery)
>> in case one of the control buttons is pressed during power-up. As with
>> QEMU, there is no chance to achieve this by hand (except for
>> artificially delaying the power-up with sleep()), this patch adds a
>> MusicPal-specific command line option -hold-button. The option takes
>> button codes and simulates those buttons as pressed on power-up.
>
> There's no reason why this should be limited to the musicpal. Better would be
> to implement it in the input layer and have to work with all machines.
Hmm... hard to argue against. Will look into this.
But I hope this doesn't make the other two patches in this serious
obsolete in your eyes. I would still like to see them go in, at least
the first one (until there is an in-tree use case for the second one).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
prev parent reply other threads:[~2008-05-21 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 23:57 [Qemu-devel] [PATCH 3/3] MusicPal: Add specific -hold-button option Jan Kiszka
2008-05-21 0:04 ` Paul Brook
2008-05-21 7:29 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833CF5F.8080908@web.de \
--to=jan.kiszka@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).