From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jyjge-0003Ud-O6 for qemu-devel@nongnu.org; Wed, 21 May 2008 04:28:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jyjgd-0003Ss-2r for qemu-devel@nongnu.org; Wed, 21 May 2008 04:28:40 -0400 Received: from [199.232.76.173] (port=56175 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jyjgc-0003Sd-Tg for qemu-devel@nongnu.org; Wed, 21 May 2008 04:28:38 -0400 Received: from ns.suse.de ([195.135.220.2]:50207 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jyjgc-00029M-Ul for qemu-devel@nongnu.org; Wed, 21 May 2008 04:28:39 -0400 Message-ID: <4833DC3F.8000604@suse.de> Date: Wed, 21 May 2008 10:24:31 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT) References: <1211283126.4314.70.camel@frecb07144> <200805202352.17807.paul@codesourcery.com> <483373BA.6090108@codemonkey.ws> <200805210205.37432.paul@codesourcery.com> <4833778C.4030209@codemonkey.ws> In-Reply-To: <4833778C.4030209@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Laurent Vivier , Paul Brook Anthony Liguori schrieb: > I don't think it's that important to try and guess the right alignment > size, 512 is probably usually sufficient, but spreading alignment > requirements of 512 throughout QEMU code is a bad idea because this is > something that's very hardware/OS specific. So better introduce a #define in block.h? > For people that care about data integrity, we should be using O_SYNC, > not O_DIRECT anyway. Should we implement an option for O_SYNC then? (not in this patch, of course) Kevin