From: Anthony Liguori <anthony@codemonkey.ws>
To: Glauber Costa <gcosta@redhat.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/3] simplify cpu_exec
Date: Wed, 21 May 2008 17:05:04 -0500 [thread overview]
Message-ID: <48349C90.1030900@codemonkey.ws> (raw)
In-Reply-To: <1211405747-18108-1-git-send-email-gcosta@redhat.com>
Glauber Costa wrote:
> This is a first attempt to simplify cpu_exec(): it has simply
> too many ifdefs, which is not a very good practice at all.
>
> Following some work I've already posted in the past, I'm moving the
> target-based ifdefs to target-xxx/helper.c, encapsuled into
> relevant functions.
>
This is a very good thing to do. My only suggestion would be to use a
name that was a bit more meaningful that cpu_pre_exec(). These hooks
seem to be loading and putting flag values for each architecture so
something like cpu_exec_load_flags() and cpu_exec_put_flags() may be
more meaningful.
Regards,
Anthony Liguori
prev parent reply other threads:[~2008-05-21 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 21:35 [Qemu-devel] [PATCH 1/3] simplify cpu_exec Glauber Costa
2008-05-21 22:05 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48349C90.1030900@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=gcosta@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).