From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JywQz-0003Bg-3J
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:05:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JywQx-0003BM-LA
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:05:20 -0400
Received: from [199.232.76.173] (port=59798 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JywQx-0003BJ-HL
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:05:19 -0400
Received: from wx-out-0506.google.com ([66.249.82.236]:55871)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JywQx-0001GE-2c
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:05:19 -0400
Received: by wx-out-0506.google.com with SMTP id h29so2572568wxd.4
	for <qemu-devel@nongnu.org>; Wed, 21 May 2008 15:05:18 -0700 (PDT)
Message-ID: <48349C90.1030900@codemonkey.ws>
Date: Wed, 21 May 2008 17:05:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1211405747-18108-1-git-send-email-gcosta@redhat.com>
In-Reply-To: <1211405747-18108-1-git-send-email-gcosta@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/3] simplify cpu_exec
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <gcosta@redhat.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

Glauber Costa wrote:
> This is a first attempt to simplify cpu_exec(): it has simply
> too many ifdefs, which is not a very good practice at all.
>
> Following some work I've already posted in the past, I'm moving the 
> target-based ifdefs to target-xxx/helper.c, encapsuled into 
> relevant functions.
>   

This is a very good thing to do.  My only suggestion would be to use a 
name that was a bit more meaningful that cpu_pre_exec().  These hooks 
seem to be loading and putting flag values for each architecture so 
something like cpu_exec_load_flags() and cpu_exec_put_flags() may be 
more meaningful.

Regards,

Anthony Liguori