From: Anthony Liguori <anthony@codemonkey.ws>
To: Glauber Costa <gcosta@redhat.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] use halted attribute for i386 too.
Date: Wed, 21 May 2008 17:08:57 -0500 [thread overview]
Message-ID: <48349D79.4090208@codemonkey.ws> (raw)
In-Reply-To: <1211406053-18211-3-git-send-email-gcosta@redhat.com>
Glauber Costa wrote:
> Unlike other architectures, i386 lacked a "halted" attribute, going
> with a flag into hflags. By using the halted attribute, we can make
> the code look like more other architectures, and simplify the code in
> some instances. In this commit, we make the code for info_cpus simpler
> in monitor.c
>
In the future, it would be better not to include both the halted change
and the IP accessor in the same function. Plus, I'm not sure that
accessor really should be doing the formating. eip will always be of
type target_ulong so it just needs a #define for the printf formating
(which is what the code does today).
Regards,
Anthony Liguori
prev parent reply other threads:[~2008-05-21 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 21:40 [Qemu-devel] [PATCH 0/2] use halted attribute for x86 Glauber Costa
2008-05-21 21:40 ` [Qemu-devel] [PATCH 2/3] Push common interrupt variables to cpu-defs.h Glauber Costa
2008-05-21 21:40 ` [Qemu-devel] [PATCH 3/3] use halted attribute for i386 too Glauber Costa
2008-05-21 22:08 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48349D79.4090208@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=gcosta@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).