From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JywUq-0004vb-27
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:09:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JywUo-0004v7-KL
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:09:19 -0400
Received: from [199.232.76.173] (port=59909 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JywUo-0004uy-DX
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:09:18 -0400
Received: from wr-out-0506.google.com ([64.233.184.233]:4824)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JywUo-0001r4-2S
	for qemu-devel@nongnu.org; Wed, 21 May 2008 18:09:18 -0400
Received: by wr-out-0506.google.com with SMTP id c49so1535114wra.19
	for <qemu-devel@nongnu.org>; Wed, 21 May 2008 15:09:17 -0700 (PDT)
Message-ID: <48349D79.4090208@codemonkey.ws>
Date: Wed, 21 May 2008 17:08:57 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1211406053-18211-1-git-send-email-gcosta@redhat.com>
	<1211406053-18211-2-git-send-email-gcosta@redhat.com>
	<1211406053-18211-3-git-send-email-gcosta@redhat.com>
In-Reply-To: <1211406053-18211-3-git-send-email-gcosta@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] use halted attribute for i386 too.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <gcosta@redhat.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

Glauber Costa wrote:
> Unlike other architectures, i386 lacked a "halted" attribute, going
> with a flag into hflags. By using the halted attribute, we can make
> the code look like more other architectures, and simplify the code in
> some instances. In this commit, we make the code for info_cpus simpler
> in monitor.c
>   

In the future, it would be better not to include both the halted change 
and the IP accessor in the same function.  Plus, I'm not sure that 
accessor really should be doing the formating.  eip will always be of 
type target_ulong so it just needs a #define for the printf formating 
(which is what the code does today).

Regards,

Anthony Liguori