From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Refactor und fix do_sendkey
Date: Thu, 22 May 2008 16:49:01 +0200 [thread overview]
Message-ID: <483587DD.6050502@bellard.org> (raw)
In-Reply-To: <483571E7.2@web.de>
Please avoid strncpy. Use pstrcpy intead.
Fabrice.
Jan Kiszka wrote:
> Looking at the sendkey implementation, planning to enhance it with a
> hold time argument, I found some potential out-of-bound access and not
> very readable code. Here is a fix for the former and a (subjective)
> improvement of the latter.
> [...]
next prev parent reply other threads:[~2008-05-22 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 13:15 [Qemu-devel] [PATCH 1/2] Refactor und fix do_sendkey Jan Kiszka
2008-05-22 14:49 ` Fabrice Bellard [this message]
2008-05-22 15:32 ` [Qemu-devel] " Jan Kiszka
2008-05-22 16:05 ` M. Warner Losh
2008-05-22 16:06 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483587DD.6050502@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).