From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JzDZj-0008M5-Gi
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:23:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JzDZh-0008KT-O5
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:23:31 -0400
Received: from [199.232.76.173] (port=48747 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JzDZh-0008KN-JV
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:23:29 -0400
Received: from e32.co.us.ibm.com ([32.97.110.150]:33116)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1JzDZh-0004pY-FE
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:23:29 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e32.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m4MGJkEH019883
	for <qemu-devel@nongnu.org>; Thu, 22 May 2008 12:19:46 -0400
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id
	m4MGNJDg097594
	for <qemu-devel@nongnu.org>; Thu, 22 May 2008 10:23:19 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m4MGNJRM002113
	for <qemu-devel@nongnu.org>; Thu, 22 May 2008 10:23:19 -0600
Message-ID: <48359DE0.9070807@us.ibm.com>
Date: Thu, 22 May 2008 11:22:56 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)
References: <1211404888-29146-1-git-send-email-aliguori@us.ibm.com>
	<200805221420.19520.paul@codesourcery.com>
In-Reply-To: <200805221420.19520.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:
>> +# Check if any targets require dyngen
>> +for target in $target_list; do
>>     
>
> You've just duplicated this logic. Please don't.
>   

The problem is the dyngen checks have to be done before the use of $cc 
which is long before the target_list loop.  In the absence of 
introducing functions in the configure script (which aren't there right 
now), I don't see a good way to avoid the duplication.

The duplication is small and it's temporary until all targets convert to 
TCG.

Regards,

Anthony Liguori

> Paul
>