From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH v10 07/11] tests/qtest: Fix tests when no KVM or TCG are present
Date: Fri, 21 Apr 2023 17:00:16 +0200 [thread overview]
Message-ID: <48389ddb-3c59-3bce-532e-012d5f92f493@redhat.com> (raw)
In-Reply-To: <20230412121829.14452-8-farosas@suse.de>
On 12/04/2023 14.18, Fabiano Rosas wrote:
> It is possible to have a build with both TCG and KVM disabled due to
> Xen requiring the i386 and x86_64 binaries to be present in an aarch64
> host.
>
> If we build with --disable-tcg on the aarch64 host, we will end-up
> with a QEMU binary (x86) that does not support TCG nor KVM.
>
> Skip tests that crash or hang in the above scenario. Do not include
> any test cases if TCG and KVM are missing.
>
> Make sure that calls to qtest_has_accel are placed after g_test_init
> in similar fashion to commit ae4b01b349 ("tests: Ensure TAP version is
> printed before other messages") to avoid TAP parsing errors.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 11 +++++++++--
> tests/qtest/boot-serial-test.c | 5 +++++
> tests/qtest/migration-test.c | 9 ++++++++-
> tests/qtest/pxe-test.c | 8 +++++++-
> tests/qtest/vmgenid-test.c | 9 +++++++--
> 5 files changed, 36 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-04-21 15:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 12:18 [PATCH v10 00/11] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 01/11] target/arm: Move cortex sysregs into a separate file Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 02/11] target/arm: Remove dead code from cpu_max_set_sve_max_vq Fabiano Rosas
2023-04-21 17:53 ` Philippe Mathieu-Daudé
2023-04-23 10:48 ` Richard Henderson
2023-04-12 12:18 ` [PATCH v10 03/11] target/arm: Extract TCG -cpu max code into a function Fabiano Rosas
2023-04-21 17:56 ` Philippe Mathieu-Daudé
2023-04-23 10:49 ` Richard Henderson
2023-04-12 12:18 ` [PATCH v10 04/11] target/arm: Do not expose all -cpu max features to qtests Fabiano Rosas
2023-04-21 17:57 ` Philippe Mathieu-Daudé
2023-04-23 10:50 ` Richard Henderson
2023-04-12 12:18 ` [PATCH v10 05/11] target/arm: Move 64-bit TCG CPUs into tcg/ Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 06/11] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-04-21 18:06 ` Philippe Mathieu-Daudé
2023-04-24 12:38 ` Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 07/11] tests/qtest: Fix tests when no KVM or TCG are present Fabiano Rosas
2023-04-20 13:59 ` Igor Mammedov
2023-04-21 15:00 ` Thomas Huth [this message]
2023-04-12 12:18 ` [PATCH v10 08/11] tests/avocado: Pass parameters to migration test Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 09/11] arm/Kconfig: Always select SEMIHOSTING when TCG is present Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 10/11] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 11/11] gitlab-ci: Check building KVM-only aarch64 target Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48389ddb-3c59-3bce-532e-012d5f92f493@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=ani@anisinha.ca \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=farosas@suse.de \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).