From: Paolo Bonzini <pbonzini@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Nicholas Piggin <npiggin@gmail.com>,
qemu-devel@nongnu.org
Cc: philmd@linaro.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Phil Dennis-Jordan" <phil@philjordan.eu>
Subject: Re: [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread
Date: Mon, 14 Apr 2025 12:57:00 +0200 [thread overview]
Message-ID: <4838b44b-49db-4f47-96da-52b9504b4f67@redhat.com> (raw)
In-Reply-To: <7e760e04-0571-48f3-9aa7-e71c631dcaff@linaro.org>
On 4/12/25 19:24, Pierrick Bouvier wrote:
> On 4/11/25 22:30, Nicholas Piggin wrote:
>> Do we actually need to hold replay mutex (or even bql) over qemu_init()?
>> Both should get dropped before we return here. But as a simple fix, I
>> guess this is okay.
>
> For the bql, I don't know the exact reason.
In general it's better to assume that there can be other threads (and
therefore you need BQL).
Also, Rust code panics if you access a BqlCell or BqlRefCell without
holding the lock.
Paolo
next prev parent reply other threads:[~2025-04-14 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 22:55 [PATCH 0/2] fix record/replay on MacOS Pierrick Bouvier
2025-04-10 22:55 ` [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread Pierrick Bouvier
2025-04-12 5:30 ` Nicholas Piggin
2025-04-12 17:24 ` Pierrick Bouvier
2025-04-14 10:25 ` Philippe Mathieu-Daudé
2025-04-14 15:24 ` Pierrick Bouvier
2025-04-15 2:41 ` Nicholas Piggin
2025-04-15 18:31 ` Pierrick Bouvier
2025-04-16 3:16 ` Nicholas Piggin
2025-04-16 18:54 ` Pierrick Bouvier
2025-04-14 10:57 ` Paolo Bonzini [this message]
2025-04-10 22:55 ` [PATCH 2/2] tests/functional/test_aarch64_replay: reenable on macos Pierrick Bouvier
2025-04-11 13:42 ` [PATCH 0/2] fix record/replay on MacOS Philippe Mathieu-Daudé
2025-04-14 15:14 ` Stefan Hajnoczi
2025-04-14 15:25 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4838b44b-49db-4f47-96da-52b9504b4f67@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=npiggin@gmail.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).