From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K16dA-0002yt-1v
	for qemu-devel@nongnu.org; Tue, 27 May 2008 17:22:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K16d8-0002xz-AF
	for qemu-devel@nongnu.org; Tue, 27 May 2008 17:22:51 -0400
Received: from [199.232.76.173] (port=37162 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K16d7-0002xo-Uo
	for qemu-devel@nongnu.org; Tue, 27 May 2008 17:22:50 -0400
Received: from relay4-v.mail.gandi.net ([217.70.178.78]:42369)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1K16d7-0004hO-L7
	for qemu-devel@nongnu.org; Tue, 27 May 2008 17:22:49 -0400
Received: from localhost (mfilter6-v.gandi.net [217.70.178.40])
	by relay4-v.mail.gandi.net (Postfix) with ESMTP id 5AD5ABA26
	for <qemu-devel@nongnu.org>; Tue, 27 May 2008 23:22:48 +0200 (CEST)
Received: from relay4-v.mail.gandi.net ([217.70.178.78])
	by localhost (mfilter6-v.mgt.gandi.net [217.70.178.40]) (amavisd-new,
	port 10024) with ESMTP id W+R6QFolQTUt for <qemu-devel@nongnu.org>;
	Tue, 27 May 2008 23:22:45 +0200 (CEST)
Received: from [84.102.211.103] (103.211.102-84.rev.gaoland.net
	[84.102.211.103])
	by relay4-v.mail.gandi.net (Postfix) with ESMTP id C4BDABA17
	for <qemu-devel@nongnu.org>; Tue, 27 May 2008 23:22:45 +0200 (CEST)
Message-ID: <483C7B69.5050501@bellard.org>
Date: Tue, 27 May 2008 23:21:45 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.
References: <1211901505-30519-1-git-send-email-gcosta@redhat.com>	<1211901505-30519-2-git-send-email-gcosta@redhat.com>	<1211901505-30519-3-git-send-email-gcosta@redhat.com>	<1211901505-30519-4-git-send-email-gcosta@redhat.com>	<483C2A20.3010309@bellard.org>
	<5d6222a80805270925t4fea901co91a0464e4e73d362@mail.gmail.com>
In-Reply-To: <5d6222a80805270925t4fea901co91a0464e4e73d362@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Glauber Costa wrote:
> On Tue, May 27, 2008 at 12:34 PM, Fabrice Bellard <fabrice@bellard.org> wrote:
>> Glauber Costa wrote:
>>> Unlike other architectures, i386 lacked a "halted" attribute, going
>>> with a flag into hflags. By using the halted attribute, we can make
>>> the code look like more other architectures, and simplify the code in
>>> some instances. In this commit, we make the code for info_cpus simpler
>>> in monitor.c
>> Good for the I386 halted attribute, as it was a mistake to put in in the
>> hflags. For the memory, hflags should contain only parts of the CPU state
>> known at translation time and should be equal to tb->flags. Most CPUs
>> (including x86 !) do not follow this sane rule.
> 
> What about HF_GIF_MASK? It looks like another case of something that
> is mistakenly put into hflags. What do you say?

This is true for: HF_GIF_MASK, HF_HIF_MASK, HF_NMI_MASK.

Fabrice.