qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Cc: glommer@gmail.com
Subject: Re: [Qemu-devel] [4609] moved halted field to CPU_COMMON
Date: Wed, 28 May 2008 20:15:31 +0200	[thread overview]
Message-ID: <483DA143.9070404@bellard.org> (raw)
In-Reply-To: <5d6222a80805281024n2adecb8bt9adf931151ae88fe@mail.gmail.com>

Glauber Costa wrote:
> On Wed, May 28, 2008 at 2:14 PM, Fabrice Bellard <fabrice@bellard.org> wrote:
>> Revision: 4609
>>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4609
>> Author:   bellard
>> Date:     2008-05-28 17:14:10 +0000 (Wed, 28 May 2008)
>>
>> Log Message:
>> -----------
>> moved halted field to CPU_COMMON
> 
> It is very good to have it commited, but I feel really embarassed to
> see no mention to me at all in the changelog.
> Even if it is a slightly modified version of the patch itself
> (although this one seems more like a subset), giving credit to the
> work I've done is a good thing. At the very least,
> it will keep developers around and motivated.

Sorry but I did redo this particular patch and I may redo the others as
well as it is faster for me to write them as I'd like to see them rather
than discussing on the mailing list.

Moreover, I consider your patches as cosmetic and as such I see no
problem in not mentionning the author.

Regards,

Fabrice.

      reply	other threads:[~2008-05-28 18:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-28 17:14 [Qemu-devel] [4609] moved halted field to CPU_COMMON Fabrice Bellard
2008-05-28 17:24 ` Glauber Costa
2008-05-28 18:15   ` Fabrice Bellard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483DA143.9070404@bellard.org \
    --to=fabrice@bellard.org \
    --cc=glommer@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).