From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K1QCW-0002gi-Ar
	for qemu-devel@nongnu.org; Wed, 28 May 2008 14:16:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K1QCU-0002fw-GF
	for qemu-devel@nongnu.org; Wed, 28 May 2008 14:16:39 -0400
Received: from [199.232.76.173] (port=37141 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K1QCU-0002fs-B1
	for qemu-devel@nongnu.org; Wed, 28 May 2008 14:16:38 -0400
Received: from relay2-v.mail.gandi.net ([217.70.178.76]:55924)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1K1QCU-0003Sg-1V
	for qemu-devel@nongnu.org; Wed, 28 May 2008 14:16:38 -0400
Message-ID: <483DA143.9070404@bellard.org>
Date: Wed, 28 May 2008 20:15:31 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [4609] moved halted field to CPU_COMMON
References: <E1K1PE3-0003Mo-5Y@cvs.savannah.gnu.org>
	<5d6222a80805281024n2adecb8bt9adf931151ae88fe@mail.gmail.com>
In-Reply-To: <5d6222a80805281024n2adecb8bt9adf931151ae88fe@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: glommer@gmail.com

Glauber Costa wrote:
> On Wed, May 28, 2008 at 2:14 PM, Fabrice Bellard <fabrice@bellard.org> wrote:
>> Revision: 4609
>>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4609
>> Author:   bellard
>> Date:     2008-05-28 17:14:10 +0000 (Wed, 28 May 2008)
>>
>> Log Message:
>> -----------
>> moved halted field to CPU_COMMON
> 
> It is very good to have it commited, but I feel really embarassed to
> see no mention to me at all in the changelog.
> Even if it is a slightly modified version of the patch itself
> (although this one seems more like a subset), giving credit to the
> work I've done is a good thing. At the very least,
> it will keep developers around and motivated.

Sorry but I did redo this particular patch and I may redo the others as
well as it is faster for me to write them as I'd like to see them rather
than discussing on the mailing list.

Moreover, I consider your patches as cosmetic and as such I see no
problem in not mentionning the author.

Regards,

Fabrice.