From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD515C7EE2C for ; Mon, 8 May 2023 10:12:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvxqK-0005RJ-Fs; Mon, 08 May 2023 06:11:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvxqH-0005QG-01 for qemu-devel@nongnu.org; Mon, 08 May 2023 06:11:41 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvxqC-0006VU-Gi for qemu-devel@nongnu.org; Mon, 08 May 2023 06:11:38 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9660af2499dso448459666b.0 for ; Mon, 08 May 2023 03:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683540693; x=1686132693; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r7f/fkBATNzqUinvH3w4ndLoZkkktG1Ww8fEUs19hSc=; b=OCCLWRprweY2bhfsQGo5cnKbVv3FqujmVlyyux2kPyfH6zQJB/aoDo5mBctZXxj/xd WYbzOIVVo+FarsAF96uee7lFG+e7bvyz/7aAZbYFPuFrB0Tg4RgBkyuZKESGL0dSrwbU DU683Zyn5jtLL35C2ULRSNKe3k6vuZTEjZdDWcC/+PSG6yygwIxBlkxgdE9e0O7zJuVg JwkW85PBx+hQvsSzILDBiN4vVzFgwJMsdO/xpB3/DXwDK+e/zPm9CAIidzWCg5KOE1Q7 6nghOoaFDNHc5wC3Q24fsiXHMbM0XrA0yKRhT3oibqfRwHt4a6sLGi2LzqvdIh2jIzHX Ei+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683540693; x=1686132693; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r7f/fkBATNzqUinvH3w4ndLoZkkktG1Ww8fEUs19hSc=; b=f/kRzwDvvtmvrKJ4CIaHcPboUnOwVd3AmSIIlCZzeiaEq+oLJ0Zi0wdxAINqifN9i2 lA9ja5R6TJK1v1nGKwBB0sySYu8oD36mQKwdSt4ooQNPHlfyw24xHujVOu6nUc6se7jE rmLjmz5V3IF+TdZfHEQepmwLCUrzsMWl2FJjNMUPXp/eb2ZY5M7Z7etfDg5R9CvtWso/ xlyS9n665oaMNH+ACTE6cK0sNsNTEsaaXGmLddnhJSEFVCofQNjs8ldLXJVGF2f3Gaxg GdEa1L8DHv526nYjaE5GZ3NhiCjnsouGWly3qY3H9sV+zsW6jYFt+eWfK2vU7UjDM3Pq KYXA== X-Gm-Message-State: AC+VfDyug0Q+dPSG+E2jULA6SEzAgTrQ2rO6DFngUdE4PLn7nK7M7l4H IJwfN1TtRXJOgV3v7uBQSMuauA== X-Google-Smtp-Source: ACHHUZ6xQAjpMdOVprzTd9OkJFtnsobvWsqbYmoiW4VdH1Z3vc4hSJLaXWDqZ9qBt0/tBjw6Mq8/MQ== X-Received: by 2002:a17:907:9345:b0:94e:c4b:4d95 with SMTP id bv5-20020a170907934500b0094e0c4b4d95mr7629334ejc.69.1683540693491; Mon, 08 May 2023 03:11:33 -0700 (PDT) Received: from [192.168.110.227] ([91.223.100.33]) by smtp.gmail.com with ESMTPSA id p25-20020a1709065dd900b0094e4eabb402sm4777421ejv.128.2023.05.08.03.11.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:11:33 -0700 (PDT) Message-ID: <483ae5ee-82e7-d964-7f95-ac45ce4bfb46@linaro.org> Date: Mon, 8 May 2023 11:11:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 07/57] accel/tcg: Honor atomicity of stores Content-Language: en-US To: Peter Maydell Cc: qemu-devel@nongnu.org, git@xen0n.name, gaosong@loongson.cn, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org References: <20230503070656.1746170-1-richard.henderson@linaro.org> <20230503070656.1746170-8-richard.henderson@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.964, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/5/23 10:28, Peter Maydell wrote: > On Wed, 3 May 2023 at 08:11, Richard Henderson > wrote: >> >> Signed-off-by: Richard Henderson >> --- >> accel/tcg/cputlb.c | 103 +++---- >> accel/tcg/user-exec.c | 12 +- >> accel/tcg/ldst_atomicity.c.inc | 491 +++++++++++++++++++++++++++++++++ >> 3 files changed, 540 insertions(+), 66 deletions(-) > > >> +/** >> + * store_atom_insert_al16: >> + * @p: host address >> + * @val: shifted value to store >> + * @msk: mask for value to store >> + * >> + * Atomically store @val to @p masked by @msk. >> + */ >> +static void store_atom_insert_al16(Int128 *ps, Int128Alias val, Int128Alias msk) >> +{ >> +#if defined(CONFIG_ATOMIC128) >> + __uint128_t *pu, old, new; >> + >> + /* With CONFIG_ATOMIC128, we can avoid the memory barriers. */ >> + pu = __builtin_assume_aligned(ps, 16); >> + old = *pu; >> + do { >> + new = (old & ~msk.u) | val.u; >> + } while (!__atomic_compare_exchange_n(pu, &old, new, true, >> + __ATOMIC_RELAXED, __ATOMIC_RELAXED)); >> +#elif defined(CONFIG_CMPXCHG128) >> + __uint128_t *pu, old, new; >> + >> + /* >> + * Without CONFIG_ATOMIC128, __atomic_compare_exchange_n will always >> + * defer to libatomic, so we must use __sync_val_compare_and_swap_16 >> + * and accept the sequential consistency that comes with it. >> + */ >> + pu = __builtin_assume_aligned(ps, 16); >> + do { >> + old = *pu; >> + new = (old & ~msk.u) | val.u; >> + } while (!__sync_bool_compare_and_swap_16(pu, old, new)); > > Comment says "__sync_val..." but code says "__sync_bool...". Which is right? Fixed the comment to __sync_*_compare_and_swap_16 r~