From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K2KTQ-0005Yc-Qn
	for qemu-devel@nongnu.org; Sat, 31 May 2008 02:21:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K2KTO-0005YG-Qd
	for qemu-devel@nongnu.org; Sat, 31 May 2008 02:21:51 -0400
Received: from [199.232.76.173] (port=59756 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K2KTO-0005YC-Hu
	for qemu-devel@nongnu.org; Sat, 31 May 2008 02:21:50 -0400
Received: from wasp.net.au ([203.190.192.17]:44161)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <brad@wasp.net.au>) id 1K2KTO-00073n-Ej
	for qemu-devel@nongnu.org; Sat, 31 May 2008 02:21:50 -0400
Message-ID: <4840EE79.5040703@wasp.net.au>
Date: Sat, 31 May 2008 10:21:45 +0400
From: Brad Campbell <brad@wasp.net.au>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=_wasp.net.au-26550-1212214908-0001-2"
Subject: [PATCH] Re: [Qemu-devel] VNC Segfault : was Re: Segfault installing
	Windows	XP 32 Bit guest on Linux 64Bit host
References: <483FF110.7020604@wasp.net.au>	<fb249edb0805300549s577f4258n865d91cfe5dc2088@mail.gmail.com>	<48400DB0.2080407@wasp.net.au>	<48401135.80009@wasp.net.au>	<4840141D.2060504@codemonkey.ws>	<48403383.6080807@wasp.net.au>	<48403DD3.80207@codemonkey.ws>	<83a4d4ca0805301106q2d605edbj5d8e0692860f98a3@mail.gmail.com>
	<4840EE0A.5070109@wasp.net.au>
In-Reply-To: <4840EE0A.5070109@wasp.net.au>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_wasp.net.au-26550-1212214908-0001-2
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Brad Campbell wrote:

> Patch attached.
> 

*fixed* patch attached.. <sigh>

Brad
-- 
"Human beings, who are almost unique in having the ability
to learn from the experience of others, are also remarkable
for their apparent disinclination to do so." -- Douglas Adams

--=_wasp.net.au-26550-1212214908-0001-2
Content-Type: text/plain; name=patch; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch"

Index: vnc.c
===================================================================
--- vnc.c	(revision 4632)
+++ vnc.c	(working copy)
@@ -307,12 +307,14 @@
     ds->width = w;
     ds->height = h;
     ds->linesize = w * vs->depth;
-    if (vs->csock != -1 && vs->has_resize && size_changed) {
-	vnc_write_u8(vs, 0);  /* msg id */
-	vnc_write_u8(vs, 0);
-	vnc_write_u16(vs, 1); /* number of rects */
-	vnc_framebuffer_update(vs, 0, 0, ds->width, ds->height, -223);
-	vnc_flush(vs);
+    if (size_changed) {
+        if (vs->csock != -1 && vs->has_resize) {
+	    vnc_write_u8(vs, 0);  /* msg id */
+	    vnc_write_u8(vs, 0);
+	    vnc_write_u16(vs, 1); /* number of rects */
+	    vnc_framebuffer_update(vs, 0, 0, ds->width, ds->height, -223);
+	    vnc_flush(vs);
+	}
 	vs->width = ds->width;
 	vs->height = ds->height;
     }

--=_wasp.net.au-26550-1212214908-0001-2--