From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K2SHv-0000mq-5c
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:42:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K2SHt-0000mV-Bq
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:42:30 -0400
Received: from [199.232.76.173] (port=38636 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K2SHt-0000mL-6n
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:42:29 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:51322)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1K2SHs-0007VP-Qp
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:42:29 -0400
Message-ID: <484163CD.9040900@web.de>
Date: Sat, 31 May 2008 16:42:21 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] Report exact PC on watchpoint hit
References: <48414AC8.7080206@web.de> <484151E8.6050806@web.de>
	<200805311511.39508.paul@codesourcery.com>
In-Reply-To: <200805311511.39508.paul@codesourcery.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigF5975F4F124AC210CAEFD220"
Sender: jan.kiszka@web.de
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigF5975F4F124AC210CAEFD220
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Paul Brook wrote:
>> @@ -2395,6 +2396,11 @@ static target_ulong check_watchpoint(tar
>> +                if (env->current_tb) {
>> +                    tb_addr =3D env->current_tb->page_addr[0];
>> +                    tb_invalidate_phys_page_range(tb_addr,
>> +                                            tb_addr+TARGET_PAGE_SIZE-=
1,
>=20
> This is wrong. env->current_tb is not what you think it it is. TB chain=
ing=20
> means we may be an any TB reachable from there.

OK, I see. But the general approach to obtain the exact PC is fine? So
should I flush the whole memory range instead?

Jan


--------------enigF5975F4F124AC210CAEFD220
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFIQWPTniDOoMHTA+kRAisSAJ4kEDekwQNhYf9DLIHoQwGEx8e3ywCffFdy
SLMLEpUucSh44Gni5epI7NE=
=PO2t
-----END PGP SIGNATURE-----

--------------enigF5975F4F124AC210CAEFD220--