From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2UIg-0007D2-Jr for qemu-devel@nongnu.org; Sat, 31 May 2008 12:51:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2UIe-0007Cq-3p for qemu-devel@nongnu.org; Sat, 31 May 2008 12:51:25 -0400 Received: from [199.232.76.173] (port=41559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2UId-0007Cn-Us for qemu-devel@nongnu.org; Sat, 31 May 2008 12:51:23 -0400 Received: from relay2-v.mail.gandi.net ([217.70.178.76]:44997) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2UId-0006nQ-I0 for qemu-devel@nongnu.org; Sat, 31 May 2008 12:51:23 -0400 Received: from localhost (mfilter2-v.gandi.net [217.70.178.36]) by relay2-v.mail.gandi.net (Postfix) with ESMTP id 97BA5135D7 for ; Sat, 31 May 2008 18:51:22 +0200 (CEST) Received: from relay2-v.mail.gandi.net ([217.70.178.76]) by localhost (mfilter2-v.gandi.net [217.70.178.36]) (amavisd-new, port 10024) with ESMTP id O5MFBta6kVwS for ; Sat, 31 May 2008 18:51:15 +0200 (CEST) Received: from [84.99.204.73] (73.204.99-84.rev.gaoland.net [84.99.204.73]) by relay2-v.mail.gandi.net (Postfix) with ESMTP id 199CF135BD for ; Sat, 31 May 2008 18:51:12 +0200 (CEST) Message-ID: <484181C4.6080002@bellard.org> Date: Sat, 31 May 2008 18:50:12 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] Debugger enhancements References: <48414AC8.7080206@web.de> In-Reply-To: <48414AC8.7080206@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, I cannot accept the patches for several reasons: 1) You mix cosmetic and functional patches. 2) The current watchpoint code is not implemented correctly so it is not safe to improve it using the same system (IMHO it should not have been commited in its current state). A correct implementation should not delay the DEBUG exception. It should be implemented like the "normal" MMU exceptions. Regards, Fabrice. Jan Kiszka wrote: > This patch series strives at improving QEMU /wrt guest debugging - for > me a very important use case of this software. > > It consists of patches that refactor and enhance the > breakpoint/watchpoint support, originally driven by the need to extend > QEMU's internal API in order to enhance (real) hardware-assisted > debugging in KVM. But as the KVM maintainer refused to merge the core of > my patches until the QEMU bits went mainline, I was forced to rebase > them immediately :->. In fact, these patches now come with even more > added value also for QEMU, ie. full watchpoint support with exact PC > addresses. > > Moreover, the series contains an old, unmerged patch of mine that > improves the debugability of SMP guests. For this submission, I > basically rebased and polished it further. I'm using it for months now > as it is de facto mandatory for SMP debugging. > > Please review! > > Jan > > > >