From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2Utz-0006x8-Lt for qemu-devel@nongnu.org; Sat, 31 May 2008 13:29:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2Uty-0006w2-6D for qemu-devel@nongnu.org; Sat, 31 May 2008 13:29:59 -0400 Received: from [199.232.76.173] (port=35696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2Uty-0006vz-3K for qemu-devel@nongnu.org; Sat, 31 May 2008 13:29:58 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:43645) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2Utx-00067n-Li for qemu-devel@nongnu.org; Sat, 31 May 2008 13:29:58 -0400 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id 94811E1D1F15 for ; Sat, 31 May 2008 19:29:56 +0200 (CEST) Received: from [88.65.37.58] (helo=[192.168.1.198]) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1K2Utv-0005z3-00 for qemu-devel@nongnu.org; Sat, 31 May 2008 19:29:55 +0200 Message-ID: <48418B13.70306@web.de> Date: Sat, 31 May 2008 19:29:55 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <48414AC8.7080206@web.de> <484181C4.6080002@bellard.org> <200805311805.03739.paul@codesourcery.com> In-Reply-To: <200805311805.03739.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig146F3EA0959347BA0C5864F5" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/5] Debugger enhancements Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig146F3EA0959347BA0C5864F5 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: >> 2) The current watchpoint code is not implemented correctly so it is n= ot >> safe to improve it using the same system (IMHO it should not have been= >> commited in its current state). A correct implementation should not >> delay the DEBUG exception. It should be implemented like the "normal" >> MMU exceptions. >=20 > On most targets watchpoint traps occur after the instruction completes,= so you=20 > have to defer the DEBUG exception. > Normal MMU faults occur before the instruction completes. OK, that explains why it is not an immediately raised exception. Still, instead of changing the TB stop condition as you suggested, I would prefer to pay the price only on watchpoint hit. Any show stopper to reuse the pattern of tb_invalidate_phys_page_range (find pc, [invalidate TB?,] regenerate TB @PC with CF_SINGLE_INSN, resume execution)? Or is you suggestion simpler and not as costly as I assume? Jan --------------enig146F3EA0959347BA0C5864F5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIQYsTniDOoMHTA+kRAiRZAJ4zhXtoo1senXenBqz4wUaUyX7+twCfQGpd eeE7vm4cH+sHGXC1YyJ6ZWI= =WK+Z -----END PGP SIGNATURE----- --------------enig146F3EA0959347BA0C5864F5--