From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2o0L-00084o-N0 for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:53:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2o0K-00084D-5t for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:53:49 -0400 Received: from [199.232.76.173] (port=37555 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2o0K-000849-1M for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:53:48 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:43233) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2o0J-0001rH-Q6 for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:53:48 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id 2F8B5DF77B74 for ; Sun, 1 Jun 2008 15:53:46 +0200 (CEST) Received: from [88.65.37.58] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1K2o0H-0000qs-00 for qemu-devel@nongnu.org; Sun, 01 Jun 2008 15:53:45 +0200 Message-ID: <4842A9E3.1090503@web.de> Date: Sun, 01 Jun 2008 15:53:39 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <48414AC8.7080206@web.de> <484181C4.6080002@bellard.org> <484188D4.70103@web.de> <48419C01.2040607@bellard.org> In-Reply-To: <48419C01.2040607@bellard.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1265A0F943F65156AE35A8D0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/5] Debugger enhancements Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1265A0F943F65156AE35A8D0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Fabrice Bellard wrote: > Jan Kiszka wrote: >> Fabrice Bellard wrote: >>> Hi, >>> >>> I cannot accept the patches for several reasons: >>> >>> 1) You mix cosmetic and functional patches. >> Do you have specific hunks in mind? I'm a bit blind ATM, not seeing >> where I changed coding style or naming for cosmetic reasons. >=20 > You renammed mem_write_pc and mem_write_vaddr. mem -> iomem dated back when I was confused about plain RAM access going through handlers that are called io_read/write. Reverted this. But write -> access is required as I changed the semantics of these variables. >=20 > BTW, why did you add 'len' and 'type' parameters to breakpoints ? >=20 > I don't think it is a good idea to say that breakpoints/watchpoints > apply to all processors. Such behavior should be handled at a higher le= vel. Yes, I agree meanwhile. Now I introduced a host-injection layer to gdbstub that handles this. All cpu_* services are per-CPU again. >=20 > It would also be interesting if the watchpoint/breakpoint implementatio= n > could be used to implement CPU watchpoints and breakpoints (I am > thinking about the x86 DRx registers here). Good point! And a hard argument to keep per-CPU breakpoint/watchpoint lists. I've already prepared my patches to tell host-injected breakpoints apart from guest-injected ones. Will now look into at least basic debug register support of x86 (which was on my list anyway). Jan --------------enig1265A0F943F65156AE35A8D0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIQqnpniDOoMHTA+kRAg16AJ9V1PR+rYSnLr8b9R1qpZBn10xB2QCfYcLL NgHT+ekicgvfTUGQKTFVRGo= =mRZw -----END PGP SIGNATURE----- --------------enig1265A0F943F65156AE35A8D0--