From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2o0w-0008Sd-5U for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:54:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2o0v-0008S0-N1 for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:54:25 -0400 Received: from [199.232.76.173] (port=37577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2o0v-0008Rl-8n for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:54:25 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:34314) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2o0u-0001z9-W8 for qemu-devel@nongnu.org; Sun, 01 Jun 2008 09:54:25 -0400 Message-ID: <4842AA0E.1010408@web.de> Date: Sun, 01 Jun 2008 15:54:22 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <48414AC8.7080206@web.de> <484181C4.6080002@bellard.org> <200805311805.03739.paul@codesourcery.com> <484199DE.3080904@bellard.org> In-Reply-To: <484199DE.3080904@bellard.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA052F1AA1C7C1AFF230571BC" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/5] Debugger enhancements Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paul Brook This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA052F1AA1C7C1AFF230571BC Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Fabrice Bellard wrote: > Paul Brook wrote: >>> 2) The current watchpoint code is not implemented correctly so it is = not >>> safe to improve it using the same system (IMHO it should not have bee= n >>> commited in its current state). A correct implementation should not >>> delay the DEBUG exception. It should be implemented like the "normal"= >>> MMU exceptions. >> On most targets watchpoint traps occur after the instruction completes= , so you=20 >> have to defer the DEBUG exception. >> Normal MMU faults occur before the instruction completes. >=20 > If this is the wanted behavior then the same system as the Self > Modifying Code on x86 should be used. Basically it consists in doing as= > a MMU fault and single stepping one instruction after. Unfortunately I > fear the implementation will be complicated. It isn't, in fact, and it allows for a few nice cleanups. I've a working version here now, based on a new singlestep_enable flag. Will re-post my whole series once I've integrated your other remarks. Jan --------------enigA052F1AA1C7C1AFF230571BC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIQqoOniDOoMHTA+kRAjZaAJ9Xhv1XXDJqiWY3WxORE/yTIZOJAgCcCVDN c66LbLrS8UpBbkr7iMWgxc0= =Zqmg -----END PGP SIGNATURE----- --------------enigA052F1AA1C7C1AFF230571BC--