[Qemu-devel] [PATCH] Move function declaration from C source to header file

[Qemu-devel] [PATCH] Move function declaration from C source to header file

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

This patch moves the declaration for function wav_start_capture from
C source to the header file.

Please apply the patch to Qemu trunk.

Thanks,
Stefan


[-- Attachment #2: audio.patch --]
[-- Type: text/x-diff, Size: 939 bytes --]

Index: audio/audio.h
===================================================================
--- audio/audio.h	(revision 4638)
+++ audio/audio.h	(working copy)
@@ -87,6 +87,9 @@
     uint64_t old_ts;
 } QEMUAudioTimeStamp;
 
+int wav_start_capture (CaptureState *s, const char *path, int freq,
+                       int bits, int nchannels);
+
 void AUD_vlog (const char *cap, const char *fmt, va_list ap);
 void AUD_log (const char *cap, const char *fmt, ...)
 #ifdef __GNUC__
Index: monitor.c
===================================================================
--- monitor.c	(revision 4638)
+++ monitor.c	(working copy)
@@ -1264,9 +1264,6 @@
 }
 
 #ifdef HAS_AUDIO
-int wav_start_capture (CaptureState *s, const char *path, int freq,
-                       int bits, int nchannels);
-
 static void do_wav_capture (const char *path,
                             int has_freq, int freq,
                             int has_bits, int bits,

Re: [Qemu-devel] [PATCH] Move function declaration from C source to header file

[Anthony Liguori]

Stefan Weil wrote:
> This patch moves the declaration for function wav_start_capture from
> C source to the header file.

It would be better to remove do_wav_capture() from monitor.c and then 
have a declaration of do_wav_capture in a header file.

Eventually, it would be good to make the monitor commands be registered 
by the various subsystems so it makes sense to move the monitor command 
implementations to their logical subsystems.

Regards,

Anthony Liguori

> Please apply the patch to Qemu trunk.
>
> Thanks,
> Stefan
>