qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Include futex.h properly.
Date: Tue, 03 Jun 2008 13:48:44 -0500	[thread overview]
Message-ID: <4845920C.8030208@codemonkey.ws> (raw)
In-Reply-To: <1212408258-30206-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:
> This wasn't building properly on my system.
> ---
>  configure            |    2 +-
>  linux-user/syscall.c |    7 ++++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 4a4ba36..f204d04 100755
> --- a/configure
> +++ b/configure
> @@ -648,7 +648,7 @@ EOF
>  # Check host NPTL support
>  cat > $TMPC <<EOF
>  #include <sched.h>
> -#include <sys/futex.h>
> +#include <linux/futex.h>
>   

I don't have a sys/futex.h on my system either.  The futex man page 
claims that linux/futex.h should be what's included.  What system is 
sys/futex.h valid on and does that system break with linux/futex.h?

Regards,

Anthony Liguori

>  void foo()
>  {
>  #if !defined(CLONE_SETTLS) || !defined(FUTEX_WAIT)
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 5f2b48a..25b9e5a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -52,9 +52,6 @@
>  //#include <sys/user.h>
>  #include <netinet/ip.h>
>  #include <netinet/tcp.h>
> -#if defined(USE_NPTL)
> -#include <sys/futex.h>
> -#endif
>  
>  #define termios host_termios
>  #define winsize host_winsize
> @@ -75,6 +72,10 @@
>  
>  #include "qemu.h"
>  
> +#if defined(USE_NPTL)
> +#include <linux/futex.h>
> +#endif
> +
>  //#define DEBUG
>  
>  #if defined(TARGET_I386) || defined(TARGET_ARM) || defined(TARGET_SPARC) \
>   

  reply	other threads:[~2008-06-03 18:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 12:04 [Qemu-devel] [PATCH] Include futex.h properly Felipe Contreras
2008-06-03 18:48 ` Anthony Liguori [this message]
2008-06-03 19:14   ` Paul Brook
2008-06-03 21:04   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4845920C.8030208@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=felipe.contreras@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).