From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3bZ6-0006pj-Sn
	for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:49:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3bZ5-0006mF-3d
	for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:49:00 -0400
Received: from [199.232.76.173] (port=52815 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3bZ4-0006m4-WE
	for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:48:59 -0400
Received: from an-out-0708.google.com ([209.85.132.246]:58751)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1K3bZ4-0005JT-TP
	for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:48:59 -0400
Received: by an-out-0708.google.com with SMTP id d18so655962and.130
	for <qemu-devel@nongnu.org>; Tue, 03 Jun 2008 11:48:57 -0700 (PDT)
Message-ID: <4845920C.8030208@codemonkey.ws>
Date: Tue, 03 Jun 2008 13:48:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Include futex.h properly.
References: <1212408258-30206-1-git-send-email-felipe.contreras@gmail.com>
In-Reply-To: <1212408258-30206-1-git-send-email-felipe.contreras@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>, Paul Brook <paul@codesourcery.com>

Felipe Contreras wrote:
> This wasn't building properly on my system.
> ---
>  configure            |    2 +-
>  linux-user/syscall.c |    7 ++++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 4a4ba36..f204d04 100755
> --- a/configure
> +++ b/configure
> @@ -648,7 +648,7 @@ EOF
>  # Check host NPTL support
>  cat > $TMPC <<EOF
>  #include <sched.h>
> -#include <sys/futex.h>
> +#include <linux/futex.h>
>   

I don't have a sys/futex.h on my system either.  The futex man page 
claims that linux/futex.h should be what's included.  What system is 
sys/futex.h valid on and does that system break with linux/futex.h?

Regards,

Anthony Liguori

>  void foo()
>  {
>  #if !defined(CLONE_SETTLS) || !defined(FUTEX_WAIT)
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 5f2b48a..25b9e5a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -52,9 +52,6 @@
>  //#include <sys/user.h>
>  #include <netinet/ip.h>
>  #include <netinet/tcp.h>
> -#if defined(USE_NPTL)
> -#include <sys/futex.h>
> -#endif
>  
>  #define termios host_termios
>  #define winsize host_winsize
> @@ -75,6 +72,10 @@
>  
>  #include "qemu.h"
>  
> +#if defined(USE_NPTL)
> +#include <linux/futex.h>
> +#endif
> +
>  //#define DEBUG
>  
>  #if defined(TARGET_I386) || defined(TARGET_ARM) || defined(TARGET_SPARC) \
>