From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Move function declaration from C source to header file
Date: Tue, 03 Jun 2008 13:53:08 -0500 [thread overview]
Message-ID: <48459314.3090909@codemonkey.ws> (raw)
In-Reply-To: <4842F20D.2070006@mail.berlios.de>
Stefan Weil wrote:
> This patch moves the declaration for function wav_start_capture from
> C source to the header file.
It would be better to remove do_wav_capture() from monitor.c and then
have a declaration of do_wav_capture in a header file.
Eventually, it would be good to make the monitor commands be registered
by the various subsystems so it makes sense to move the monitor command
implementations to their logical subsystems.
Regards,
Anthony Liguori
> Please apply the patch to Qemu trunk.
>
> Thanks,
> Stefan
>
prev parent reply other threads:[~2008-06-03 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 19:01 [Qemu-devel] [PATCH] Move function declaration from C source to header file Stefan Weil
2008-06-03 18:53 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48459314.3090909@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).