From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3bdL-0001LU-Nb for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:53:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3bdJ-0001Ko-V3 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:53:23 -0400 Received: from [199.232.76.173] (port=48911 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3bdJ-0001Ki-Oi for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:53:21 -0400 Received: from hs-out-0708.google.com ([64.233.178.248]:33860) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3bdJ-00066n-K4 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 14:53:21 -0400 Received: by hs-out-0708.google.com with SMTP id k27so1480888hsc.2 for ; Tue, 03 Jun 2008 11:53:20 -0700 (PDT) Message-ID: <48459314.3090909@codemonkey.ws> Date: Tue, 03 Jun 2008 13:53:08 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Move function declaration from C source to header file References: <4842F20D.2070006@mail.berlios.de> In-Reply-To: <4842F20D.2070006@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefan Weil wrote: > This patch moves the declaration for function wav_start_capture from > C source to the header file. It would be better to remove do_wav_capture() from monitor.c and then have a declaration of do_wav_capture in a header file. Eventually, it would be good to make the monitor commands be registered by the various subsystems so it makes sense to move the monitor command implementations to their logical subsystems. Regards, Anthony Liguori > Please apply the patch to Qemu trunk. > > Thanks, > Stefan >