From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3bsX-0001TC-Tg for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:09:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3bsW-0001Rx-5g for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:09:05 -0400 Received: from [199.232.76.173] (port=38100 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3bsV-0001Rg-St for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:09:03 -0400 Received: from an-out-0708.google.com ([209.85.132.242]:20569) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3bsV-0000d4-U5 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 15:09:04 -0400 Received: by an-out-0708.google.com with SMTP id d18so658030and.130 for ; Tue, 03 Jun 2008 12:09:03 -0700 (PDT) Message-ID: <484596C2.8030908@codemonkey.ws> Date: Tue, 03 Jun 2008 14:08:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Use standard header for offsetof References: <4842DE67.9090207@mail.berlios.de> In-Reply-To: <4842DE67.9090207@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefan Weil wrote: > This patch adds the standard header stddef.h to all files which call > offsetof. > It also removes several local definitions of offsetof which are no > longer needed. > > If you prefer standard headers for standard macros instead of local > definitions > (like I do), you can add this patch to Qemu trunk. I don't understand why you're adding #include to files that do not define offsetof. What's the rationale for that? Regards, Anthony Liguori > Thanks, > Stefan >