Re: [Qemu-devel] [PATCH] gdbstub: monitor fixes v3

[Anthony Liguori <anthony@codemonkey.ws>]

Jason Wessel wrote:
> Based on some comments in the qemu irc channel, here is a revised
> implementation of gdb monitor pass through patches.
>
> At a future time if it is truly "high value" the gdb specific monitor
> commands will be migrated into the qemu monitor, OR at such time that
> the user emulation begins to use the monitor.  Presently, the only
> user of the gdb specific variables is a debugger and the controls
> exist to alter the behavior from the debugger, even if you have to
> find the debugger console window some where in a debugger UI...
>
> I would guess the average user never uses the debugger.  Out of the
> small community of users that use the debugger probably even fewer
> will use these new controls. These type of controls are intended for
> extremely low level debugging, hence the reason they exist in the
> "Advanced Section" in the first place :-)
>
> please apply in order:
> gdb_single_step_monitor_cmd.patch
>   

Please separate patches in individual emails in the future.

In general, I don't like the approach this takes using the monitor 
multiplexing support to simulate the ability to have multiple monitors.  
Either we should properly support having multiple monitors, or we should 
dedicate the monitor to the gdb interface.

That is, I'd rather see this patch implemented as -monitor gdb then 
taking over the monitor like it does.  I'm concerned that the 
multiplexing is going to break monitor redirection when the GDB session 
is active.

Regards,

Anthony Liguori


> gdb_monitor_plus_qemu_monitor.patch
>
>
> Thanks,
> Jason.
>
>