From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Use standard header for offsetof
Date: Tue, 03 Jun 2008 16:24:52 -0500 [thread overview]
Message-ID: <4845B6A4.2070301@codemonkey.ws> (raw)
In-Reply-To: <4845B193.8030209@mail.berlios.de>
Stefan Weil wrote:
> Anthony Liguori schrieb:
>>
>> I don't understand why you're adding #include <stdef.h> to files that
>> do not define offsetof. What's the rationale for that?
>>
>> Regards,
>>
>> Anthony Liguori
>>
> There were several possible ways to replace the defines for offsetof.
> After removing the defines, I could
>
> 1) include stddef.h at the places where offsetof was defined formerly
This seems like the most logically thing to do to me. Otherwise, you're
unnecessarily increasing the number of #include's in C files.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-06-03 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 17:37 [Qemu-devel] [PATCH] Use standard header for offsetof Stefan Weil
2008-06-02 6:21 ` Johannes Schindelin
2008-06-03 19:08 ` Anthony Liguori
2008-06-03 21:03 ` Stefan Weil
2008-06-03 21:24 ` Anthony Liguori [this message]
2008-06-06 19:44 ` Stefan Weil
2008-06-06 19:58 ` Andreas Färber
2008-06-09 10:30 ` Ian Jackson
2008-06-06 20:32 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4845B6A4.2070301@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).