From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3e0D-0000tN-FB for qemu-devel@nongnu.org; Tue, 03 Jun 2008 17:25:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3e0B-0000qE-1v for qemu-devel@nongnu.org; Tue, 03 Jun 2008 17:25:08 -0400 Received: from [199.232.76.173] (port=51417 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3e0A-0000q9-QP for qemu-devel@nongnu.org; Tue, 03 Jun 2008 17:25:06 -0400 Received: from wx-out-0506.google.com ([66.249.82.232]:58215) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3e0A-0001lM-JY for qemu-devel@nongnu.org; Tue, 03 Jun 2008 17:25:06 -0400 Received: by wx-out-0506.google.com with SMTP id h29so1174309wxd.4 for ; Tue, 03 Jun 2008 14:25:06 -0700 (PDT) Message-ID: <4845B6A4.2070301@codemonkey.ws> Date: Tue, 03 Jun 2008 16:24:52 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Use standard header for offsetof References: <4842DE67.9090207@mail.berlios.de> <484596C2.8030908@codemonkey.ws> <4845B193.8030209@mail.berlios.de> In-Reply-To: <4845B193.8030209@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefan Weil wrote: > Anthony Liguori schrieb: >> >> I don't understand why you're adding #include to files that >> do not define offsetof. What's the rationale for that? >> >> Regards, >> >> Anthony Liguori >> > There were several possible ways to replace the defines for offsetof. > After removing the defines, I could > > 1) include stddef.h at the places where offsetof was defined formerly This seems like the most logically thing to do to me. Otherwise, you're unnecessarily increasing the number of #include's in C files. Regards, Anthony Liguori