From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3trc-0006YA-09
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:21:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3trb-0006Xl-7J
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:21:19 -0400
Received: from [199.232.76.173] (port=48341 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3tra-0006Xb-VJ
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:21:19 -0400
Received: from wx-out-0506.google.com ([66.249.82.227]:47097)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1K3taw-0003Mw-Rg
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:04:06 -0400
Received: by wx-out-0506.google.com with SMTP id h29so74938wxd.4
	for <qemu-devel@nongnu.org>; Wed, 04 Jun 2008 07:04:06 -0700 (PDT)
Message-ID: <4846A0C9.9050106@codemonkey.ws>
Date: Wed, 04 Jun 2008 09:03:53 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <2c9e3f91af3dc46f86cdf5cf11d62512@foo>
	<OF8A88C382.3F4B1AFA-ON8525745E.00231217@rapid7.com>
In-Reply-To: <OF8A88C382.3F4B1AFA-ON8525745E.00231217@rapid7.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] New qemu-img convert -B option to
 preserve the COW aspect of images and/or re-base them
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc Bevand <m.bevand@gmail.com>
Cc: qemu-devel@nongnu.org

Marc Bevand wrote:
> If a disk image hd_a is a copy-on-write image based on the backing
> file hd_base, it is currently impossible to use qemu-img to convert
> hd_a to hd_b (possibly using another disk image format) while keeping
> hd_b a copy-on-write image of hd_base. qemu-img also doesn't provide a
> feature that would let an enduser re-base a image, for example: adjust
> hd_a's backing file name from hd_base to hd_base2 if it had to change
> for some reason.
>
> This patch solves the 2 above problems by adding a new qemu-img
> convert -B option which works as described below. This is a generic
> feature that should work with ANY disk image format supporting backing
> files:
>   

Looks good to me.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori