From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3vca-0006AL-0S for qemu-devel@nongnu.org; Wed, 04 Jun 2008 12:13:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3vcY-00069b-DZ for qemu-devel@nongnu.org; Wed, 04 Jun 2008 12:13:55 -0400 Received: from [199.232.76.173] (port=35121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3vcY-00069W-4n for qemu-devel@nongnu.org; Wed, 04 Jun 2008 12:13:54 -0400 Received: from wx-out-0506.google.com ([66.249.82.233]:2619) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3vcX-0007Ne-Qt for qemu-devel@nongnu.org; Wed, 04 Jun 2008 12:13:53 -0400 Received: by wx-out-0506.google.com with SMTP id h29so117506wxd.4 for ; Wed, 04 Jun 2008 09:13:53 -0700 (PDT) Message-ID: <4846BF33.9030002@codemonkey.ws> Date: Wed, 04 Jun 2008 11:13:39 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction References: <4846AD03.5070908@suse.de> In-Reply-To: <4846AD03.5070908@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Alexander Graf wrote: > VMRUN stores the IP which is used to return to the instruction after > the VMRUN in case of a VMEXIT. Due to recent changes, this does not > happen anymore and a VMEXIT simply returns to the VMRUN instruction. > > Alex The open-coded + 3 bothers me. Are there any circumstances that a prefix could be used with vmrun that would change the instruction length? vmrun doesn't appear to be affected by prefixes but I don't see anything in the AMD manual specifically forbidding it. Regards, Anthony Liguori