From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction
Date: Wed, 04 Jun 2008 12:56:50 -0500 [thread overview]
Message-ID: <4846D762.5090704@codemonkey.ws> (raw)
In-Reply-To: <A14E5D57-E66F-4A02-9C56-EE5B1229F06F@suse.de>
Alexander Graf wrote:
>
> On Jun 4, 2008, at 6:13 PM, Anthony Liguori wrote:
>
>> Alexander Graf wrote:
>>> VMRUN stores the IP which is used to return to the instruction after
>>> the VMRUN in case of a VMEXIT. Due to recent changes, this does not
>>> happen anymore and a VMEXIT simply returns to the VMRUN instruction.
>>>
>>> Alex
>>
>> The open-coded + 3 bothers me. Are there any circumstances that a
>> prefix could be used with vmrun that would change the instruction
>> length? vmrun doesn't appear to be affected by prefixes but I don't
>> see anything in the AMD manual specifically forbidding it.
>
> This is true and it bothers me as well. I am open to suggestions how
> to receive the IP after the instruction that is about to be executed.
> Probably this could be done in translate.c?
Looks like Fabrice's commit handles it nicely.
Regards,
Anthony Liguori
> Alex
prev parent reply other threads:[~2008-06-04 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 14:56 [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction Alexander Graf
2008-06-04 16:13 ` Anthony Liguori
2008-06-04 16:19 ` Alexander Graf
2008-06-04 17:56 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4846D762.5090704@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).