From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3xES-00043H-UR
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 13:57:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3xEQ-0003z9-R6
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 13:57:08 -0400
Received: from [199.232.76.173] (port=56779 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3xEQ-0003z2-Mg
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 13:57:06 -0400
Received: from wx-out-0506.google.com ([66.249.82.231]:2537)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1K3xEQ-0002Rv-D6
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 13:57:06 -0400
Received: by wx-out-0506.google.com with SMTP id h29so151045wxd.4
	for <qemu-devel@nongnu.org>; Wed, 04 Jun 2008 10:57:04 -0700 (PDT)
Message-ID: <4846D762.5090704@codemonkey.ws>
Date: Wed, 04 Jun 2008 12:56:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] VMRUN should store the RIP after the
	instruction
References: <4846AD03.5070908@suse.de> <4846BF33.9030002@codemonkey.ws>
	<A14E5D57-E66F-4A02-9C56-EE5B1229F06F@suse.de>
In-Reply-To: <A14E5D57-E66F-4A02-9C56-EE5B1229F06F@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Alexander Graf wrote:
>
> On Jun 4, 2008, at 6:13 PM, Anthony Liguori wrote:
>
>> Alexander Graf wrote:
>>> VMRUN stores the IP which is used to return to the instruction after 
>>> the VMRUN in case of a VMEXIT. Due to recent changes, this does not 
>>> happen anymore and a VMEXIT simply returns to the VMRUN instruction.
>>>
>>> Alex
>>
>> The open-coded  + 3 bothers me.  Are there any circumstances that a 
>> prefix could be used with vmrun that would change the instruction 
>> length?  vmrun doesn't appear to be affected by prefixes but I don't 
>> see anything in the AMD manual specifically forbidding it.
>
> This is true and it bothers me as well. I am open to suggestions how 
> to receive the IP after the instruction that is about to be executed. 
> Probably this could be done in translate.c?

Looks like Fabrice's commit handles it nicely.

Regards,

Anthony Liguori

> Alex