From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3xWN-0002OI-Dp
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 14:15:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3xWM-0002M9-BM
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 14:15:38 -0400
Received: from [199.232.76.173] (port=35977 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3xWL-0002Lb-Qz
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 14:15:37 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:42157)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1K3xWL-0006Ud-IA
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 14:15:37 -0400
Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215])
	by fmmailgate02.web.de (Postfix) with ESMTP id 5E0B9DFFBEE6
	for <qemu-devel@nongnu.org>; Wed,  4 Jun 2008 20:15:36 +0200 (CEST)
Received: from [88.65.37.28] (helo=[139.25.109.167])
	by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226) id 1K3xWK-00073F-00
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 20:15:36 +0200
Message-ID: <4846DBC8.1090301@web.de>
Date: Wed, 04 Jun 2008 20:15:36 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <48357281.1090501@web.de>	<fb249edb0806040316k3db37572l5ce11c275a0fdb4a@mail.gmail.com>
	<20080604132556.GA28895@mx.loc>
In-Reply-To: <20080604132556.GA28895@mx.loc>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigDC9171879B541AFED22199B5"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH 2/2] Enhance sendkey with key hold time
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDC9171879B541AFED22199B5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Bernhard Fischer wrote:
> On Wed, Jun 04, 2008 at 12:16:48PM +0200, andrzej zaborowski wrote:
>> On 22/05/2008, Jan Kiszka <jan.kiszka@web.de> wrote:
>=20
>>>  +static void release_keys(void *opaque)
>>>  +{
>>>  +    int keycode;
>>>  +
>>>  +    while (nb_pending_keycodes > 0) {
>=20
> Perhaps just doing a post decrement on the nb_pending would be cleaner.=


I prefer a separate statement for this but...

>=20
>>>  +        keycode =3D keycodes[nb_pending_keycodes-1];
>>>  +        if (keycode & 0x80)
>>>  +            kbd_put_keycode(0xe0);
>>>  +        kbd_put_keycode(keycode | 0x80);
>>>  +        nb_pending_keycodes--;
>>>  +    }

I agree that code reordering can save us the "-1".

Thanks,
Jan


--------------enigDC9171879B541AFED22199B5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFIRtvIniDOoMHTA+kRAlWmAJ96/KyQYW6u70ZXyF/iGjcDg5punACeIJkt
1TCI2cNWxANewYRYPzUz1/o=
=ZBPR
-----END PGP SIGNATURE-----

--------------enigDC9171879B541AFED22199B5--