From: Jan Kiszka <jan.kiszka@web.de>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand
Date: Thu, 05 Jun 2008 00:29:03 +0200 [thread overview]
Message-ID: <4847172F.8060704@web.de> (raw)
In-Reply-To: <20080604220124.GA15504@networkno.de>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
Thiemo Seufer wrote:
> Jan Kiszka wrote:
>> Fabrice Bellard wrote:
>>> Hi,
>>>
>>> I tend to dislike such macros...
>> Why?
>
> IHMO it isn't a useful abstraction (and therefore code obfuscation).
What possible misunderstandings do you see in its naming? Granted, I'm
used to it as this scheme is standard under Linux (with variations for
CPU hotplugging).
The code becomes shorter and thus quicker graspable IMO. And I guess the
more QEMU heads for SMP guests, there more often this pattern will
occur. My debugger SMP fix already comes with 5 more use cases.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
next prev parent reply other threads:[~2008-06-04 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 19:56 [Qemu-devel] [PATCH] Introduce foreach_cpu shorthand Jan Kiszka
2008-06-03 20:18 ` Anthony Liguori
2008-06-04 12:39 ` Fabrice Bellard
2008-06-04 18:21 ` [Qemu-devel] " Jan Kiszka
2008-06-04 22:01 ` Thiemo Seufer
2008-06-04 22:29 ` Jan Kiszka [this message]
2008-06-05 1:26 ` Paul Brook
2008-06-05 7:11 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4847172F.8060704@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).