From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K41Tl-00018l-FW for qemu-devel@nongnu.org; Wed, 04 Jun 2008 18:29:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K41Tj-00018R-4A for qemu-devel@nongnu.org; Wed, 04 Jun 2008 18:29:12 -0400 Received: from [199.232.76.173] (port=40173 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K41Ti-00018O-Re for qemu-devel@nongnu.org; Wed, 04 Jun 2008 18:29:10 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:45461) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K41Ti-0002Bu-Ka for qemu-devel@nongnu.org; Wed, 04 Jun 2008 18:29:10 -0400 Message-ID: <4847172F.8060704@web.de> Date: Thu, 05 Jun 2008 00:29:03 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand References: <4845A1D6.5050005@web.de> <48468CED.9000706@bellard.org> <4846DD33.2070206@web.de> <20080604220124.GA15504@networkno.de> In-Reply-To: <20080604220124.GA15504@networkno.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7AD29970069B234D3CFD477D" Sender: jan.kiszka@web.de Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7AD29970069B234D3CFD477D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thiemo Seufer wrote: > Jan Kiszka wrote: >> Fabrice Bellard wrote: >>> Hi, >>> >>> I tend to dislike such macros... >> Why? >=20 > IHMO it isn't a useful abstraction (and therefore code obfuscation). What possible misunderstandings do you see in its naming? Granted, I'm used to it as this scheme is standard under Linux (with variations for CPU hotplugging). The code becomes shorter and thus quicker graspable IMO. And I guess the more QEMU heads for SMP guests, there more often this pattern will occur. My debugger SMP fix already comes with 5 more use cases. Jan --------------enig7AD29970069B234D3CFD477D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIRxc1niDOoMHTA+kRAt4XAJ4mwwdEIZ3BxS0Lg2N1+t6vBTxRHQCeMfw0 Xe0E/8H38IMKi46Z/P9KY/Y= =+ZuP -----END PGP SIGNATURE----- --------------enig7AD29970069B234D3CFD477D--