From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K49eB-0008Mf-A6 for qemu-devel@nongnu.org; Thu, 05 Jun 2008 03:12:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K49e8-0008MT-Sn for qemu-devel@nongnu.org; Thu, 05 Jun 2008 03:12:29 -0400 Received: from [199.232.76.173] (port=47453 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K49e8-0008MQ-Mv for qemu-devel@nongnu.org; Thu, 05 Jun 2008 03:12:28 -0400 Received: from mx20.gnu.org ([199.232.41.8]:37000) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K49e7-0007M7-T6 for qemu-devel@nongnu.org; Thu, 05 Jun 2008 03:12:28 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K49e6-0004aK-QR for qemu-devel@nongnu.org; Thu, 05 Jun 2008 03:12:27 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id 31F8ADFF1F73 for ; Thu, 5 Jun 2008 09:11:56 +0200 (CEST) Received: from [88.65.37.28] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1K49dc-0002YC-00 for qemu-devel@nongnu.org; Thu, 05 Jun 2008 09:11:56 +0200 Message-ID: <484791B3.9010505@web.de> Date: Thu, 05 Jun 2008 09:11:47 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4845A1D6.5050005@web.de> <48468CED.9000706@bellard.org> <4846DD33.2070206@web.de> <200806050226.42967.paul@codesourcery.com> In-Reply-To: <200806050226.42967.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDD9473DADBF0286DD744822D" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDD9473DADBF0286DD744822D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: > [foreach_cpu] >>> I tend to dislike such macros... >> Why? >=20 > I agree with Fabrice in this case. Iterating over all cpus isn't a=20 > particularly onerous task to start with. Using bizarre macros means tha= t the=20 > code no longer looks like normal C. OK, got it. Looks like tastes are different here. >=20 >> My debugger SMP fix already comes with 5 more use cases. >=20 > I'm unconvinced by SMP debugger support. FSF gdb isn't currently capabl= e of=20 > handling SMP targets, so whatever you're doing is likely to be an ugly = hack. Well, it makes things useable on SMP hosts. Please suggest alternatives if you think that this is the wrong approach, but leaving this unfixed would be a mistake IMO. Also note that gdb used for this case is in no way different from gdb used with the kgdb stub. In both cases, the debugger (silently) expects global scope of breakpoints. And that is what my patch ensures + it enables focus switching for the gdbstub. Again, I'm open for alternative approaches to achieve comparable usability. I can only repeat that debugging SMP guest _depends_ on such changes. Jan --------------enigDD9473DADBF0286DD744822D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIR5G7niDOoMHTA+kRAkd/AJ9uA0A4WYO5FfVGq8TRcb6SeSG+SQCdHHMy u0j20JqdH8aT6YZNPYJ92VQ= =oKr6 -----END PGP SIGNATURE----- --------------enigDD9473DADBF0286DD744822D--